Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of retirement snapshots #191

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

0xAurelius
Copy link
Collaborator

Still has some issues related to changed data types and fields being moved around/renamed, esp. the "token" field being gone, the feeAmount being the wrong datatype (int vs. decimal) and the "pool" field being Bytes | null instead of string

@0xAurelius 0xAurelius force-pushed the port-retirement-metrics branch 2 times, most recently from ffe3bde to 717a372 Compare October 7, 2024 20:23
@0xAurelius 0xAurelius marked this pull request as ready for review October 7, 2024 20:24
@0xAurelius 0xAurelius changed the title Initial port of retirement snapshots with bugs Port of retirement snapshots Oct 8, 2024
@0xAurelius 0xAurelius force-pushed the port-retirement-metrics branch from 379acb6 to 1609a2c Compare October 9, 2024 15:33
@0xAurelius 0xAurelius force-pushed the port-retirement-metrics branch from 07c83ee to 3f195ac Compare November 4, 2024 07:51
@0xAurelius 0xAurelius force-pushed the port-retirement-metrics branch 2 times, most recently from 5dd762a to f4a0c74 Compare November 25, 2024 09:17
@0xAurelius 0xAurelius changed the base branch from main to staging January 2, 2025 18:36
@0xAurelius 0xAurelius force-pushed the port-retirement-metrics branch from f4a0c74 to e5ad9b1 Compare January 2, 2025 18:37
@0xAurelius
Copy link
Collaborator Author

I'm still struggling to get this working properly, MCO2 retired stats on CarbonMetrics are only showing 0.001 retired (maybe a decimal issue?) and carbonCreditSnapshots are not being populated properly...

@psparacino
Copy link
Collaborator

I'm still struggling to get this working properly, MCO2 retired stats on CarbonMetrics are only showing 0.001 retired (maybe a decimal issue?) and carbonCreditSnapshots are not being populated properly...

which deployment are you working with? Spun up a test here: #328 for moss metrics and in the test at least seems to be ok...? the snapshots don't work for mco2 or all credits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants