Add support for full LND RPC API #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update library to use openssl instead of rustls * Include docstring in lib module
* Add all proto files to build * Got new proto build partially working * Put generated files into separate gen dir * Add invoices client and example for add hold invoice rpc. * Fix error message in hold invoice example * Start adding all protos * Got proto build working with either vendor folder or lnd repo path * Remove proto output dir and generated dir * Add functions to connect to all LND services * Update docstring and readme example code * Fix clippy lint in get channel
yzernik
changed the title
|
I just tested it from https://crates.io/crates/tonic_openssl_lnd and it works great, I think this is big add, thank you @yzernik |
|
@Kixunil I updated the PR to revert some of the unnecessary changes I made to the connect function signature, so the diff should be much smaller now. |
|
What a monster PR Jonathan. This is awesome. I will use walletrpc. But it's apparently going to take some time to review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for all of the LND RPC API's (#15).
I also switched from using
rustlstoopensslfor the TLS certificate handling, because of this issue.I added another example program in the
examplesdirectory showing how to use theadd_hold_invoiceRPC method ininvoicesrpc, as an example of a non-lnrpcRPC call.This may change the MSRV, not sure if that is important. I have published this fork as a crate if anyone wants to use it already: https://crates.io/crates/tonic_openssl_lnd