Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing proto files #15

Open
benthecarman opened this issue Jun 24, 2022 · 4 comments
Open

Add missing proto files #15

benthecarman opened this issue Jun 24, 2022 · 4 comments

Comments

@benthecarman
Copy link
Contributor

This only includes the lightning.proto file. Would be beneficial to have all the missing protos to have access to the full lnd api

@Kixunil
Copy link
Owner

Kixunil commented Jul 1, 2022

Yeah, someone talked to me about this over e-mail. Doesn't seem to be trivial but probably doable.

@yzernik
Copy link

yzernik commented Jul 23, 2022

@benthecarman I made a fork of this repo with support for the full LND API, and published the crate here in case anyone wants to use it: https://crates.io/crates/tonic_openssl_lnd

@Kixunil
Copy link
Owner

Kixunil commented Jul 24, 2022

FYI, I want to review your PR, but it's quite large and I don't have much time and mental energy to focus on such a large thing. Perhaps splitting it in two parts - ssl and more proto files would help me but I can't promise it will.

@yzernik
Copy link

yzernik commented Jul 30, 2022

@Kixunil Sure, I'll try to split it into a few small PR's. My intention was not to create a competing library, but I just needed these features urgently. I'll probably have some time to do this next week.

okjodom pushed a commit to orbitalturtle/tonic_lnd that referenced this issue Dec 22, 2023
chore: run cargo clippy --fix and cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants