Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Korean Translation #143

Merged
merged 10 commits into from
Feb 14, 2015
Merged

[RFR] Korean Translation #143

merged 10 commits into from
Feb 14, 2015

Conversation

kimdhoe
Copy link
Contributor

@kimdhoe kimdhoe commented Feb 14, 2015

No description provided.

KittyGiraudel
KittyGiraudel reviewed Feb 14, 2015
View reviewed changes
ko/_syntax.md
</div>
</div>

리스트에 새로운 아이템을 추가할 때는, 언제나 제공된 API를 이용하세요. 수동���로 새로운 아이템을 추가하려고 하지 마세요.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice ��� here. Is it intended? Only on my side perhaps?

@KittyGiraudel
Copy link
Owner

This looks great to me, except for the comment I made. I'll merge once fixed.

@KittyGiraudel KittyGiraudel mentioned this pull request Feb 14, 2015
Closed
@KittyGiraudel KittyGiraudel changed the title Korean Translation [RFR] Korean Translation Feb 14, 2015
@kimdhoe
Copy link
Contributor Author

kimdhoe commented Feb 14, 2015

Not intended definitely. I'll fix it right away.

@KittyGiraudel
Copy link
Owner

Thanks. I have not carefully reviewed the whole thing so there might be some other occurrences of this.

@kimdhoe
Copy link
Contributor Author

kimdhoe commented Feb 14, 2015

Right. I will review it once more.

@kimdhoe
Copy link
Contributor Author

kimdhoe commented Feb 14, 2015

OK! Hopefully everything is good this time.

KittyGiraudel added a commit that referenced this pull request Feb 14, 2015
@KittyGiraudel
Merge pull request #143 from kimdhoe/ko
1c4d74e 
[RFR] Korean Translation
@KittyGiraudel KittyGiraudel merged commit 1c4d74e into KittyGiraudel:gh-pages Feb 14, 2015
@KittyGiraudel
Copy link
Owner

Terrific: http://sass-guidelin.es/ko/! Thank you so much. :)

@kimdhoe
Copy link
Contributor Author

kimdhoe commented Feb 14, 2015

It is my pleasure to do :) Thanks!
I just realized that hrefs in hash anchors also should be translated. Links in toc are all broken. I will deal with it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdhoe @KittyGiraudel