Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation #137

Closed
KittyGiraudel opened this issue Feb 11, 2015 · 10 comments
Closed

Korean translation #137

KittyGiraudel opened this issue Feb 11, 2015 · 10 comments

Comments

@KittyGiraudel
Copy link
Owner

Ping @kimdhoe.

If you have any specific question regarding your translation, feel free to get in touch here. You will find all guidelines about translating this project in the meta issue: #96.

Cheers! :)

@kimdhoe
Copy link
Contributor

kimdhoe commented Feb 11, 2015

Great! Thanks for the guidelines. For both of them :)

@kimdhoe
Copy link
Contributor

kimdhoe commented Feb 14, 2015

Hey Hugo! Almost finished Korean translation. I have one question. Wondering if it would be OK to apply some exceptions to the guidelines.

I transliterated these untranslated words into Korean letters as it sounds. I think it would be more proper for Korean readers.

  • front end / back end (noun)
  • front-end / back-end (adjective)
  • media query / media queries
  • placeholder

Also, I translated Responsive Web Design to 반응형 웹 디자인, which is a direct translation and widely used term in Korea.

@KittyGiraudel
Copy link
Owner Author

Hey Kim!

No problem with those exceptions. I understand it really is specific to the language, so I trust your judgement on this.

Feel free to open a PR when you're done. I'll review (what I can review of course) and merge it. Also, be sure to add a ko (is that right?) key to both files in _data folder: https://github.com/HugoGiraudel/sass-guidelines/tree/gh-pages/_data. :)

@kimdhoe
Copy link
Contributor

kimdhoe commented Feb 14, 2015

Oh and, in Warnings and Errors section,

"Basically any mixin or function expecting a specific type or argument could throw an error if something went wrong, or display a warning when doing an assumption."

It is meant to be of, is it not?

I will open a PR soon!

@KittyGiraudel
Copy link
Owner Author

Yeah, could be.

@KittyGiraudel
Copy link
Owner Author

Relevant PR: #143. Closing.

@KittyGiraudel
Copy link
Owner Author

Please, could you submit a PR to update this line: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L150?

Adding something like ", translated by ..." in Korean, with Markdown links would be nice. Kind of what has been done for the Polish translation: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L100.

@KittyGiraudel
Copy link
Owner Author

Ping @kimdhoe.

Do you feel like you could translate version 1.1.0? There are not many additions but that would be nice for your translation to remain up-to-date. You can see the changes here: #125.

Tell me what you think. :)

@kimdhoe
Copy link
Contributor

kimdhoe commented Jul 6, 2015

It's already been a season since 1.1.0?! I'll speed up a little.

@KittyGiraudel
Copy link
Owner Author

No problem. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants