-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korean translation #137
Comments
Great! Thanks for the guidelines. For both of them :) |
Hey Hugo! Almost finished Korean translation. I have one question. Wondering if it would be OK to apply some exceptions to the guidelines. I transliterated these untranslated words into Korean letters as it sounds. I think it would be more proper for Korean readers.
Also, I translated Responsive Web Design to 반응형 웹 디자인, which is a direct translation and widely used term in Korea. |
Hey Kim! No problem with those exceptions. I understand it really is specific to the language, so I trust your judgement on this. Feel free to open a PR when you're done. I'll review (what I can review of course) and merge it. Also, be sure to add a |
Oh and, in Warnings and Errors section,
It is meant to be of, is it not? I will open a PR soon! |
Yeah, could be. |
Relevant PR: #143. Closing. |
Please, could you submit a PR to update this line: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L150? Adding something like ", translated by ..." in Korean, with Markdown links would be nice. Kind of what has been done for the Polish translation: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L100. |
It's already been a season since 1.1.0?! I'll speed up a little. |
No problem. :) |
Ping @kimdhoe.
If you have any specific question regarding your translation, feel free to get in touch here. You will find all guidelines about translating this project in the meta issue: #96.
Cheers! :)
The text was updated successfully, but these errors were encountered: