Support = in record initialisation
#4519
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nrc
requested review from
adamchalmers and
jtran
and removed request for
adamchalmers
|
Frontend tests are failing. They format code (using unparser.rs), so even though they haven't been updated, they're getting the updated syntax. I think we should update the TS to generate and expect the new syntax. Looking good otherwise, though. |
| @@ -75,6 +75,9 @@ fn unparse(test_name: &str) { | |||
| }; | |||
| // Check recasting the AST produces the original string. | |||
| let actual = ast.recast(&Default::default(), 0); | |||
| if matches!(std::env::var("EXPECTORATE").as_deref(), Ok("overwrite")) { | |||
| std::fs::write(format!("tests/{test_name}/input.kcl"), &actual).unwrap(); | |||
There was a problem hiding this comment.
Nice. I've been running these with cargo insta test --accept but I don't think we can detect that in the same way.
nrc
force-pushed
the
nrc-record-init
branch
2 times, most recently
from
9cd5191
to
831bbe5
Compare
nrc
force-pushed
the
nrc-record-init
branch
2 times, most recently
from
640d05c
to
fce0b52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4519 +/- ##
==========================================
- Coverage 85.99% 85.99% -0.01%
==========================================
Files 81 81
Lines 29520 29527 +7
==========================================
+ Hits 25385 25391 +6
- Misses 4135 4136 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Nick Cameron <[email protected]>
No description provided.