Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(boards): cleanup pins and keys, disable battery reporting #163

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

ReFil
Copy link
Collaborator

@ReFil ReFil commented Jun 1, 2023

This cleans up the I/O mapping of the board, brings the keymap in line with the latest version of the manual and also functionally disables battery reporting, solving an issue on macs where it will repeatedly wake the computer from sleep. This is a stopgap until a new major firmware update where the bluetooth service for battery reporting will be removed

ReFil added 2 commits May 25, 2023 21:42
Remove unmapped keys from matrix, remap transform in line with this, unmap associated IO, bring keymap in line with manual
This increases battery reporting interval to the extent it never happens, preventing spurious wakeups on macs. Will be totally disabled in V3.0
@fuchodeveloper
Copy link

👍🏼 glad to see the “frequent wake from sleep” bug being worked on.

@ReFil ReFil merged commit 7e20d8d into KinesisCorporation:V2.0 Jun 1, 2023
@trein
Copy link

trein commented Jun 15, 2023

The refactoring commit creates major conflicts for anyone who has a custom keymap, which I imagine is everyone. I'm essentially rebasing from upstream and reverting the entire refactoring. That makes me wonder:

  • How do you envision the workflow that users need to follow to update their forks? Are you expecting them to understand the changes and cherry-pick only the commits they want? I'm not sure if the average user will have the technical knowledge and/or the patience to go over all the changes trying to figure out what commit they need to cherry-pick and the changes it depends on.

  • Is there a better way to organize the files so that the keymap configuration is never touched? Or maybe changes should be backwards compatible and properly versioned? It sounds to me that this refactoring should have been part of a different major version and the bluetooth change something that should have been back-ported to earlier versions.

@ReFil
Copy link
Collaborator Author

ReFil commented Jun 15, 2023

Apologies for a lack of clarity surrounding this update, unfortunately there was no option but to push a breaking change as this resolved several outstanding issues permanently. all that needs to be done to bring an old keymap file up to new is removing the highlighted extraneous &none keys in the .keymap file and editing the keymap.json file to match. everything else should work without any changes.

244104004-b9d696e0-6c6b-4f2c-a95e-85458b6ffb0e

@trein
Copy link

trein commented Jun 16, 2023

Thank you so much for the explanation above, @ReFil. Really appreciated.

I think I'm failing to understand how the refactoring and the bluetooth change are related. From my limited understanding of the code, they seem pretty independent. Couldn't the bluetooth fix be pushed to V2.0 and the breaking changes to V3.0 (or some other versioning scheme that this repo is following)?

kadoyau added a commit to kadoyau/Adv360-Pro-ZMK that referenced this pull request Jul 12, 2023
kadoyau added a commit to kadoyau/Adv360-Pro-ZMK that referenced this pull request Jul 12, 2023
kadoyau added a commit to kadoyau/Adv360-Pro-ZMK that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants