Use CMake's builtin functionality for pre-compiled headers #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #2326 |
`glslang_pch()` did manual mangling of the compiler flags to enable pre-compiled headers. I couldn't get this approach to work with the `MachineIndependent` subdirectory, but fortunately CMake has added first-class support for precompiled headers in 3.16, which does work with subdirectories. Moved `glslang_pch()` to the other global function declarations. `glslang_pch()` is a no-op when using CMake earlier than `3.16`. CMake's PCH implementation does not need the `pch.cpp` files, so just remove them.
|
@jeffbolznv do you think this new way of doing PCH will work for you? Anyone: What versions of CMake are used on dev boxes? Thanks. |
|
I tried it with Visual Studio and didn't have any problems. It would be good if somebody tried it with ninja + MSVC, I had all sorts of problems trying to get ninja to work with PCH and eventually gave up. |
Yes, I believe it does. Using the The builtin CMake integration in VS 2019 by default uses ninja, without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glslang_pch()did manual mangling of the compiler flags to enable pre-compiled headers.I couldn't get this approach to work with the
MachineIndependentsubdirectory / static lib, but fortunately CMake has added first-class support for precompiled headers in 3.16, which does work with the new static libraries.Moved
glslang_pch()to the other global function declarations.glslang_pch()is a no-op when using CMake earlier than3.16.CMake's PCH implementation does not need the
pch.cppfiles, so just remove them.