Remove GLSLANG_BUILD_PIC flag #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GenericCodeGen` and `MachineIndependent` were missing from the generated visual studio solutions. Add these.
On closer inspection, it appears that nearly all the targets use the `POSITION_INDEPENDENT_CODE` target option anyway. Simplify all this away by always being PIC.
|
Based on #2325. |
ben-clayton
added a commit
to ben-clayton/vkb
that referenced
this pull request
Jul 7, 2020
The very short existance of `GLSLANG_BUILD_PIC` was removed in KhronosGroup/glslang#2326 as it became clear that nearly all the targets use the `POSITION_INDEPENDENT_CODE` target option, so the new targets also use this. As all glslang targets now use `POSITION_INDEPENDENT_CODE`, there's no need for `GLSLANG_BUILD_PIC`.
dj2
pushed a commit
to google/vkb
that referenced
this pull request
Jul 7, 2020
The very short existance of `GLSLANG_BUILD_PIC` was removed in KhronosGroup/glslang#2326 as it became clear that nearly all the targets use the `POSITION_INDEPENDENT_CODE` target option, so the new targets also use this. As all glslang targets now use `POSITION_INDEPENDENT_CODE`, there's no need for `GLSLANG_BUILD_PIC`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On closer inspection, it appears that nearly all the targets use the
POSITION_INDEPENDENT_CODEtarget option anyway.Simplify all this away by always being PIC.