printf: Support 64-bit floats #8341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 226793. |
|
CI Vulkan-ValidationLayers build # 17162 running. |
spencer-lunarg
commented
Jul 31, 2024
| @@ -635,5 +637,8 @@ void Module::PostProcess() { | |||
| } | |||
| } | |||
|
|
|||
| // TODO - Currently this is not tied into validation layers callback, should be using LogWarning/LogError | |||
| void InternalWarning(const char* message) { std::cout << "[Internal Shader Instrumentation Warning] " << message << '\n'; } | |||
There was a problem hiding this comment.
next PR after this will be to hook in the call back so I can move all the validation from #8294 into here as it should be done in this part of the code anyway
|
CI Vulkan-ValidationLayers build # 17162 passed. |
arno-lunarg
approved these changes
Jul 31, 2024
| double_bitmask_ |= 1 << expanded_parameter_count_; | ||
|
|
||
| // TODO (Also in GPU-AV) need to detect if shaderInt64 is supported or not before forcing this on | ||
| module_.AddCapability(spv::CapabilityInt64); |
There was a problem hiding this comment.
What happens if CapabilityInt64 is not supported? Will the user get noticed?
There was a problem hiding this comment.
its just technically invalid SPIR-V and a VU like anything else
from what I could see, Float64 is more rare than Int64 so assume they would support this... but we should add a way to check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7143