printf: Add Basic DebugPrintf string validation #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 219086. |
|
CI Vulkan-ValidationLayers build # 17080 running. |
|
CI Vulkan-ValidationLayers build # 17080 passed. |
artem-lunarg
approved these changes
Jul 17, 2024
spencer-lunarg
force-pushed
the
spencer-lunarg-printf-debug
branch
from
549bf06 to
e6f1271
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 220063. |
|
CI Vulkan-ValidationLayers build # 17087 running. |
|
CI Vulkan-ValidationLayers build # 17087 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do zero validation for debug printf, things like
debugPrintfEXT("vector of %f", myInt);or other variations will blindly start printing garbage and there is nothing validating itChecked and Renderdoc follows the same formatting so this should be universal (left comment)
To start these are all warnings, but some things feel like errors (so we might change them in future)