Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with action() not being a getter on ITraceSession #556

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix issues with action() not being a getter on ITraceSession #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd5a7d9
Fix issues with action() not being a getter on ITraceSession
kevinbarabash Mar 2, 2023
dcbc1e6
add missing files
kevinbarabash Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-candles-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/wonder-stuff-server-google": patch
---

Fix ITraceSession interface
1 change: 0 additions & 1 deletion packages/wonder-stuff-server-google/src/trace-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ export const traceImpl = (
};

return {
// @ts-expect-error [FEI-5011] - TS2322 - Type 'string' is not assignable to type '() => string'.
get action() {
return action;
},
Expand Down
2 changes: 1 addition & 1 deletion packages/wonder-stuff-server-google/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export interface ITraceSession {
/**
* The name of the action being traced as provided when it was started.
*/
action(): string;
get action(): string;
/**
* Add a label to the trace session.
*
Expand Down