Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with action() not being a getter on ITraceSession #556

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

kevinbarabash
Copy link
Contributor

Summary:

For some reason the 'get' modifier on the 'action()' getter in ITRaceSession was dropped when the files were converted to TypeScript. I checked the other getters we have, which are on classes, but they weren't affected. I suspect it's an issue with the codemod. I'll investigate later and will patch is possible.

Issue: None

Test plan:

  • yarn typecheck

@kevinbarabash kevinbarabash self-assigned this Mar 2, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

🦋 Changeset detected

Latest commit: dcbc1e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/wonder-stuff-server-google Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team March 2, 2023 18:23
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/selfish-candles-call.md, packages/wonder-stuff-server-google/src/trace-impl.ts, packages/wonder-stuff-server-google/src/types.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@kevinbarabash kevinbarabash requested review from somewhatabstract and a team March 2, 2023 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Size Change: 0 B

Total Size: 4.37 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/es/index.browser.js 1.73 kB
packages/wonder-stuff-sentry/dist/es/index.browser.js 1.66 kB
packages/wonder-stuff-testing/dist/es/index.browser.js 976 B

compressed-size-action

@kevinbarabash kevinbarabash merged commit 769f3d5 into main Mar 2, 2023
@kevinbarabash kevinbarabash deleted the fix-interface-getter branch March 2, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants