FEI-4957.7: Generate .js.flow files from .d.ts files #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42c88ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: 0 B Total Size: 4.36 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 845 843 -2
Branches 233 224 -9
=========================================
- Hits 845 843 -2
Continue to review full report at Codecov.
|
jeresig
approved these changes
Feb 16, 2023
kevinbarabash
force-pushed
the
fei-4957.6
branch
from
a6152d6 to
faf05a6
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
58fbf40 to
c0c606e
Compare
kevinbarabash
force-pushed
the
fei-4957.6
branch
from
faf05a6 to
dc95691
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
c0c606e to
695f26e
Compare
kevinbarabash
force-pushed
the
fei-4957.6
branch
from
dc95691 to
cdec808
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
695f26e to
81ba228
Compare
kevinbarabash
force-pushed
the
fei-4957.6
branch
from
cdec808 to
35eac00
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
81ba228 to
37c5f87
Compare
kevinbarabash
force-pushed
the
fei-4957.6
branch
from
35eac00 to
07c827d
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
37c5f87 to
29374c8
Compare
kevinbarabash
force-pushed
the
fei-4957.7
branch
from
29374c8 to
42c88ea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const command = `yarn flowgen ${inFile} -o ${outFile} --add-flow-header`; | ||
|
|
||
| try { | ||
| execSync(command, {cwd: rootDir}); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to generate .js.flow files from our .d.ts files so that wonder-stuff packages can be used in codebases that are still using Flow. This PR adds a build script to run flowgen on each .d.ts file in the dist folder of each package.
It also adds a script for removing .d.ts files that were generated from .test.ts files. Both scripts are written in TypeScript and use swc-node/register to run. I've added package.json scripts to make this easier. I'll research this further to see if there's a nice shebang approach we can use in the future, but this should suffice for now.
Issue: FEI-4957
Test plan: