Skip to content

Commit

Permalink
remove watch:types, people can use 'yarn typecheck --watch', update C…
Browse files Browse the repository at this point in the history
…I to delete .d.ts files for tests
  • Loading branch information
kevinbarabash committed Feb 16, 2023
1 parent c48e416 commit dc95691
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ jobs:
run: yarn build

- name: Build Types
run: yarn build:types && rm -rf packages/*/dist/**/__types__
# There isn't an easy way for us to type check our tests without
# also including them in dist folder when we build the .d.ts files
# so we have to manually remove them.
# TODO(kevin): Figure out how to have the `build:types` script do this.
run: yarn build:types && rm -rf packages/*/dist/**/__tests__

# Linting / type checking
- name: Eslint
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"build:prodsizecheck": "rollup -c build-settings/rollup.config.js --configPlatforms='browser' --configFormats='esm' --configEnvironment='production'",
"build:types": "yarn tsc --build --verbose tsconfig-build.json",
"watch": "rollup -c build-settings/rollup.config.js --watch",
"watch:types": "yarn build:types --watch",
"clean": "rm -rf packages/wonder-stuff-*/dist && rm -rf packages/wonder-stuff-*/node_modules && rm -f packages/*/tsconfig.tsbuildinfo",
"coverage": "yarn run jest --coverage",
"format": "prettier --write .",
Expand Down

0 comments on commit dc95691

Please sign in to comment.