Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflowify wonder-stuff #1001

Merged
merged 2 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-boxes-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/eslint-plugin": major
---

Remove Flow related rules
8 changes: 8 additions & 0 deletions .changeset/light-apes-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@khanacademy/wonder-stuff-render-environment-jsdom": patch
"@khanacademy/wonder-stuff-render-server": patch
"@khanacademy/wonder-stuff-server": patch
"@khanacademy/wonder-stuff-core": patch
---

Update comments to no longer reference Flow
9 changes: 4 additions & 5 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ coverage:

status:
project:
default: on
default: true
patch:
default: off
changes:
Expand All @@ -14,14 +14,13 @@ coverage:
comment:
layout: "header, reach, diff, flags, files, footer"
behavior: default
require_changes: no
require_base: no
require_head: yes
require_changes: false
require_base: false
require_head: true

ignore:
- "build-settings/*.js"
- "utils/*.js"
- "packages/**/dist/index.js"
- "packages/**/types/**/*.ts"
- "packages/**/examples/**/*.ts"
- "packages/**/*.flowtest.js"
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ We love code reviews. If there are open pull requests, please feel free to revie

#### Automated

To ensure code quality, we use prettier, flow, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.
To ensure code quality, we use prettier, TypeScript, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.

To execute these operations outside of a pull request or commit operation, you can use `yarn`.

- `yarn flow`
- `yarn typecheck`
- `yarn lint`
- `yarn test`

Expand Down
5 changes: 0 additions & 5 deletions packages/eslint-plugin-khan/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ eslint plugin with our set of custom rules for various things

## Rules

- [khan/flow-array-type-style](docs/flow-array-type-style.md)
- [khan/flow-exact-props](docs/flow-exact-props.md)
- [khan/flow-exact-state](docs/flow-exact-state.md)
- [khan/flow-no-one-tuple](docs/flow-no-one-tuple.md)
- [khan/imports-requiring-flow](docs/imports-requiring-flow.md)
- [khan/jest-async-use-real-timers](docs/jest-async-use-real-timers.md)
- [khan/jest-enzyme-matchers](docs/jest-enzyme-matchers.md)
- [khan/react-no-method-jsx-attribute](docs/react-no-method-jsx-attribute.md)
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin-khan/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// NOTE(kevinb): This should only be used by eslint-plugin-khan
module.exports = {
presets: [
"@babel/preset-flow",
[
"@babel/preset-env",
{
Expand Down
29 changes: 0 additions & 29 deletions packages/eslint-plugin-khan/docs/flow-array-type-style.md

This file was deleted.

44 changes: 0 additions & 44 deletions packages/eslint-plugin-khan/docs/flow-exact-props.md

This file was deleted.

38 changes: 0 additions & 38 deletions packages/eslint-plugin-khan/docs/flow-exact-state.md

This file was deleted.

33 changes: 0 additions & 33 deletions packages/eslint-plugin-khan/docs/flow-no-one-tuple.md

This file was deleted.

107 changes: 0 additions & 107 deletions packages/eslint-plugin-khan/docs/imports-requiring-flow.md

This file was deleted.

1 change: 0 additions & 1 deletion packages/eslint-plugin-khan/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"devDependencies": {
"@babel/eslint-parser": "^7.22.15",
"@babel/preset-env": "^7.23.2",
"@babel/preset-flow": "^7.22.15",
"@babel/preset-react": "^7.22.15",
"@swc-node/register": "^1.6.8",
"@swc/core": "^1.3.93",
Expand Down
44 changes: 0 additions & 44 deletions packages/eslint-plugin-khan/src/rules/flow-array-type-style.js

This file was deleted.

Loading
Loading