Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflowify wonder-stuff #1001

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Deflowify wonder-stuff #1001

merged 2 commits into from
Jan 9, 2024

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Jan 9, 2024

Summary:

We're finished the TypeScript migration so we no longer need Flow related stuff kicking around.

Issue: FEI-5445

Test plan:

  • yarn test
  • cd packages/eslint-plugin-khan
  • yarn test

@kevinbarabash kevinbarabash self-assigned this Jan 9, 2024
Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: c59921c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@khanacademy/eslint-plugin Major
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-server Patch
@khanacademy/wonder-stuff-core Patch
@khanacademy/eslint-config Major
@khanacademy/wonder-stuff-ci Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team January 9, 2024 18:35
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .codecov.yml, CONTRIBUTING.md, yarn.lock, .changeset/calm-boxes-exist.md, .changeset/light-apes-matter.md, packages/eslint-plugin-khan/README.md, packages/eslint-plugin-khan/babel.config.js, packages/eslint-plugin-khan/package.json, packages/wonder-stuff-server/src/trace-impl.ts, packages/wonder-stuff-server/src/trace.ts, packages/eslint-plugin-khan/src/rules/index.ts, packages/wonder-stuff-core/src/__tests__/entries.test.ts, packages/wonder-stuff-render-server/src/handlers/handle-error.ts, packages/wonder-stuff-render-server/src/handlers/make-render-handler.ts, packages/wonder-stuff-render-server/src/handlers/__tests__/make-render-handler.test.ts, packages/wonder-stuff-server/src/middleware/__tests__/request-authentication.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@kevinbarabash kevinbarabash requested review from a team and removed request for a team January 9, 2024 18:35
Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thank you!

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Size Change: 0 B

Total Size: 4.67 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.13 kB

compressed-size-action

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #1001 (c59921c) into main (d6296d4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1001   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         1393      1390    -3     
  Branches       359       343   -16     
=========================================
- Hits          1393      1390    -3     
Files Coverage Δ
...r-stuff-render-server/src/handlers/handle-error.ts 100.00% <ø> (ø)
...-render-server/src/handlers/make-render-handler.ts 100.00% <ø> (ø)
packages/wonder-stuff-server/src/trace-impl.ts 100.00% <ø> (ø)
packages/wonder-stuff-server/src/trace.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6296d4...c59921c. Read the comment docs.

Copy link
Member

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks 🎉

@kevinbarabash kevinbarabash merged commit 23a8585 into main Jan 9, 2024
8 checks passed
@kevinbarabash kevinbarabash deleted the deflowify branch January 9, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants