Fix active state styling for tertiary button #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7306025 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
beaesguerra
commented
Jun 24, 2024
| @@ -495,7 +495,7 @@ export const _generateStyles = ( | |||
| active: { | |||
| color: light ? fadedColor : activeColor, | |||
| ":after": { | |||
| height: 1, | |||
| height: theme.size.height.tertiaryHover, | |||
There was a problem hiding this comment.
|
Size Change: -1 B (0%) Total Size: 96.9 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
+ Coverage 94.25% 95.58% +1.33%
==========================================
Files 248 248
Lines 29395 29395
Branches 2416 2475 +59
==========================================
+ Hits 27706 28097 +391
+ Misses 1644 1281 -363
+ Partials 45 17 -28
... and 43 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…e state of the tertiary button so that the hover and active styling are consistent
beaesguerra
force-pushed
the
update-tertiary-button-active-state
branch
from
e7b8ce2 to
7306025
Compare
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-vgqhvotzmb.chromatic.com/ Chromatic results:
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (4d8d453) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2259"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use the same theme token for the height of the underline on the active state of the tertiary button so that the hover and active styling are consistent
Issue: WB-1025
Test plan:
Screen Recording:
Before & After
tertiary-button-states.mov