Merge 7306025 into f099cf8

Khan · Jun 24, 2024 · 4d8d453 · 4d8d453
2 parents f099cf8 + 7306025
commit 4d8d453
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/light-swans-thank.md b/.changeset/light-swans-thank.md
@@ -0,0 +1,5 @@
+---
+"@khanacademy/wonder-blocks-button": patch
+---
+
+Fix inconsistent underline height in the active state of the tertiary button.
diff --git a/__docs__/wonder-blocks-button/button.stories.tsx b/__docs__/wonder-blocks-button/button.stories.tsx
@@ -127,7 +127,7 @@ export const Tertiary: StoryComponentType = {
         // eslint-disable-next-line testing-library/prefer-user-event
         await fireEvent.mouseDown(button);
         await expect(innerLabel).toHaveStyle("color: rgb(27, 80, 179)");
-        await expect(computedStyleLabel.height).toBe("1px");
+        await expect(computedStyleLabel.height).toBe("2px");
         await expect(computedStyleLabel.color).toBe("rgb(27, 80, 179)");
     },
 };

diff --git a/packages/wonder-blocks-button/src/components/button-core.tsx b/packages/wonder-blocks-button/src/components/button-core.tsx
@@ -495,7 +495,7 @@ export const _generateStyles = (
             active: {
                 color: light ? fadedColor : activeColor,
                 ":after": {
-                    height: 1,
+                    height: theme.size.height.tertiaryHover,
                     background: light ? fadedColor : activeColor,
                 },
             },