-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure npm credentials are set by publish_snapshot.sh
#422
Conversation
🦋 Changeset detectedLatest commit: 6f7d9ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (a8fbdbf). As a result, we did not |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage ? 65.98%
=======================================
Files ? 487
Lines ? 107108
Branches ? 7376
=======================================
Hits ? 70674
Misses ? 36434
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
Size Change: 0 B Total Size: 635 kB ℹ️ View Unchanged
|
exit 1 | ||
fi | ||
|
||
verify_env() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of lines moved here. I've gathered bits of functionality into functions so it's a bit less of a "massive wall of procedural functionality". Now if you skip to line 107 you can follow the functionality more easily (I hope!). The new lines are in create_npmrc
(lines 88-99)!
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
publish_snapshot.sh
publish_snapshot.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Bash to me 👍
utils/publish-snapshot.sh
Outdated
create_npmrc | ||
|
||
|
||
exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this exit
here prevent the following lines from running? Like yarn build
and yarn extract-strings
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yikes! Thanks for catching this. I'd added it to test something locally. Removed!!!
Summary:
We've seen Github action failures in the "Publish npm snapshot" job. This is because the npm auth info has not been provided (this is done automatically by the changesets Github Action, but we aren't using it here because we're publishing a snapshot.
This PR mimics what the changesets Github Action does by creating a
.npmrc
file with the credentials in it.Issue: "none"
Test plan:
Create a new PR after landing this one.
Ensure that the "Publish npm snapshot" job succeeds.