-
Notifications
You must be signed in to change notification settings - Fork 350
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure npm credentials are set by
publish_snapshot.sh
(#422)
## Summary: We've seen Github action failures in the "Publish npm snapshot" job. This is because the npm auth info has not been provided (this is done automatically by the changesets Github Action, but we aren't using it here because we're publishing a snapshot. This PR mimics what the changesets Github Action [does](https://github.com/changesets/action/blob/8c3f5f5637a95a2327e78d5dabcf357978aedcbb/src/index.ts#L58..L85) by creating a `.npmrc` file with the credentials in it. Issue: "none" ## Test plan: Create a new PR after landing this one. Ensure that the "Publish npm snapshot" job succeeds. Author: jeremywiebe Reviewers: jeremywiebe, handeyeco Required Reviewers: Approved By: handeyeco Checks: ✅ finish_coverage, ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Flow, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald, ✅ Check builds for changes in size (ubuntu-latest, 16.x) Pull Request URL: #422
- Loading branch information
1 parent
05c0bca
commit a18ef7e
Showing
2 changed files
with
90 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters