[Unlimited Polygon] Fix for creating concave polygons. #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (0e366f1) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2009If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2009 |
|
Size Change: -7 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
nishasy
approved these changes
Dec 14, 2024
Merged
somewhatabstract
added a commit
that referenced
this pull request
Dec 16, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs - [#2009](#2009) [`b09d19b7b`](b09d19b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing bug in creating concave shapes in unlimited polygons. - [#1978](#1978) [`81632c326`](81632c3) Thanks [@nishasy](https://github.com/nishasy)! - [Polygon] Remove duplicate points when determining if a polygon can be closed - [#1999](#1999) [`278527b08`](278527b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing open polygon scoring issues within exercises and editors. ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs - [#1978](#1978) [`81632c326`](81632c3) Thanks [@nishasy](https://github.com/nishasy)! - [Polygon] Remove duplicate points when determining if a polygon can be closed - [#1999](#1999) [`278527b08`](278527b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing open polygon scoring issues within exercises and editors. - Updated dependencies \[[`763d2d0f1`](763d2d0), [`b09d19b7b`](b09d19b), [`81632c326`](81632c3), [`278527b08`](278527b)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moving the Polygon component lower in the stack to ensure the rect component is on top. This is necessary to allow users to draw a polygon that is concaved, because the Polyline blocks the click events.
Screen.Recording.2024-12-13.at.4.06.39.PM.mov
Issue: LEMS-2679
Test plan:
Go to: http://localhost:6006/?path=/story/perseus-widgets-interactive-graph--unlimited-polygon-with-mafs.
Draw a polygon that is concave and notice it should allow you to draw it.