-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnlimitedPolygon] Fix open polygon scoring issues. #1999
Conversation
…with coordinates.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (cf99339) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1999 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1999 |
Size Change: +261 B (+0.02%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach. I like how straightforward it is.
packages/perseus/src/widgets/interactive-graphs/interactive-graph.testdata.ts
Outdated
Show resolved
Hide resolved
packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-state.test.ts
Show resolved
Hide resolved
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs - [#2009](#2009) [`b09d19b7b`](b09d19b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing bug in creating concave shapes in unlimited polygons. - [#1978](#1978) [`81632c326`](81632c3) Thanks [@nishasy](https://github.com/nishasy)! - [Polygon] Remove duplicate points when determining if a polygon can be closed - [#1999](#1999) [`278527b08`](278527b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing open polygon scoring issues within exercises and editors. ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs - [#1978](#1978) [`81632c326`](81632c3) Thanks [@nishasy](https://github.com/nishasy)! - [Polygon] Remove duplicate points when determining if a polygon can be closed - [#1999](#1999) [`278527b08`](278527b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing open polygon scoring issues within exercises and editors. - Updated dependencies \[[`763d2d0f1`](763d2d0), [`b09d19b7b`](b09d19b), [`81632c326`](81632c3), [`278527b08`](278527b)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2014](#2014) [`763d2d0f1`](763d2d0) Thanks [@somewhatabstract](https://github.com/somewhatabstract)! - Migrate off deprecated ID generation APIs
Summary:
This PR fixes and adds 3 things to the Unlimited Polygon Experience:
Issue: LEMS-2682
Test plan:
invalid
valid
score.