Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sync-dependencies.ts script #1569

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Run sync-dependencies.ts script #1569

merged 5 commits into from
Aug 28, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Aug 28, 2024

Summary:

We're running into TS issues that I think is caused by using incompatible WB/WS versions. So I ran sync-dependencies.ts to get us up-to-sync with Webapp.

See: https://khanacademy.slack.com/archives/C01AZ9H8TTQ/p1724797503623059

@handeyeco handeyeco self-assigned this Aug 28, 2024
@khan-actions-bot khan-actions-bot requested a review from a team August 28, 2024 17:17
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Aug 28, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to package.json, yarn.lock, .changeset/pink-tigers-deny.md, dev/package.json, packages/keypad-context/package.json, packages/math-input/package.json, packages/perseus/package.json, packages/perseus-editor/package.json, packages/simple-markdown/package.json, packages/perseus/src/__tests__/__snapshots__/renderer.test.tsx.snap, packages/perseus/src/widgets/__tests__/__snapshots__/dropdown.test.ts.snap, packages/perseus/src/widgets/__tests__/__snapshots__/explanation.test.ts.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Size Change: -143 B (-0.02%)

Total Size: 860 kB

Filename Size Change
packages/kas/dist/es/index.js 38.3 kB -21 B (-0.05%)
packages/math-input/dist/es/index.js 78 kB -3 B (0%)
packages/perseus-editor/dist/es/index.js 277 kB -21 B (-0.01%)
packages/perseus-linter/dist/es/index.js 22.2 kB -14 B (-0.06%)
packages/perseus/dist/es/index.js 417 kB -69 B (-0.02%)
packages/pure-markdown/dist/es/index.js 3.66 kB -15 B (-0.41%)
ℹ️ View Unchanged
Filename Size
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Aug 28, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ec19460) and published it to npm. You
can install it using the tag PR1569.

Example:

yarn add @khanacademy/perseus@PR1569

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1569

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

Comment on lines 61 to 62
"react-router": "5.3.4",
"react-router-dom": "5.3.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I wonder if these are even used/needed by math-input? We don't import them anywhere. I wonder if this is just cruft from when we moved Perseus back into this repo. No change necessary, just musing.

@handeyeco handeyeco changed the title run sync script Run sync-dependencies.ts script Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.86%. Comparing base (21a908e) to head (ec19460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   70.34%   70.86%   +0.52%     
==========================================
  Files         521      524       +3     
  Lines      107316   107349      +33     
  Branches     5513    11030    +5517     
==========================================
+ Hits        75489    76075     +586     
+ Misses      31711    31274     -437     
+ Partials      116        0     -116     

Impacted file tree graph

see 110 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a908e...ec19460. Read the comment docs.

@handeyeco handeyeco merged commit 40d0b67 into main Aug 28, 2024
12 checks passed
@handeyeco handeyeco deleted the sync-deps branch August 28, 2024 19:46
benchristel pushed a commit that referenced this pull request Sep 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/[email protected]

### Minor Changes

-   [#1572](#1572) [`efced74db`](efced74) Thanks [@benchristel](https://github.com/benchristel)! - In the interactive graph widget, focus movable points on mouse interaction

### Patch Changes

-   [#1552](#1552) [`873f10790`](873f107) Thanks [@nishasy](https://github.com/nishasy)! - Update dependency on wonder-blocks-form


-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp


-   [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom.


-   [#1576](#1576) [`598f7450f`](598f745) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Small re-organization of PhET widget code - no functional changes


-   [#1567](#1567) [`070430166`](0704301) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Add a reducer action for removing unlimited points


-   [#1573](#1573) [`50c1b19e5`](50c1b19) Thanks [@benchristel](https://github.com/benchristel)! - Internal: fix incorrect comment

-   Updated dependencies \[[`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Minor Changes

-   [#1534](#1534) [`d446d4251`](d446d42) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove 'strings' prop from ContentPreview (we'll pull it from context)

### Patch Changes

-   [#1552](#1552) [`873f10790`](873f107) Thanks [@nishasy](https://github.com/nishasy)! - Update dependency on wonder-blocks-form


-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp


-   [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom.


-   [#1534](#1534) [`d446d4251`](d446d42) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Ensure 'React' is imported in ContentPreview component.

-   Updated dependencies \[[`efced74db`](efced74), [`873f10790`](873f107), [`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e), [`598f7450f`](598f745), [`070430166`](0704301), [`50c1b19e5`](50c1b19)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp

## @khanacademy/[email protected]

### Patch Changes

-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp


-   [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom.

-   Updated dependencies \[[`40d0b67a8`](40d0b67)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

-   Updated dependencies \[[`40d0b67a8`](40d0b67)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp

## @khanacademy/[email protected]

### Patch Changes

-   [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp


-   [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom.

-   Updated dependencies \[[`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

Author: khan-actions-bot

Reviewers: benchristel

Required Reviewers:

Approved By: benchristel

Checks: ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants