-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing resize behavior for Expression Widget #1548
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +16 B (0%) Total Size: 860 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 70.38% 70.97% +0.58%
==========================================
Files 521 524 +3
Lines 107315 107349 +34
Branches 7796 11652 +3856
==========================================
+ Hits 75538 76192 +654
+ Misses 31587 31157 -430
+ Partials 190 0 -190
... and 146 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f5346d5) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1548 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My only concerns:
- Failing TS check
- I wonder if we need to update all WB/WS at the same time?
Yeah the weird failing type check made me think I needed to update all of them at the same time. Will keep digging into why it's mis-behaving, and see if it's needed. |
Okay after wrangling with the typing I can summarize why it's there. The update to tooltip also appears to have included a dependency update to the color object Tooltip accepts. So to fix this I just needed to update the tokens package version. So the only packages updated are tooltip, popover, and tokens. 😊 |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1572](#1572) [`efced74db`](efced74) Thanks [@benchristel](https://github.com/benchristel)! - In the interactive graph widget, focus movable points on mouse interaction ### Patch Changes - [#1552](#1552) [`873f10790`](873f107) Thanks [@nishasy](https://github.com/nishasy)! - Update dependency on wonder-blocks-form - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp - [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom. - [#1576](#1576) [`598f7450f`](598f745) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Small re-organization of PhET widget code - no functional changes - [#1567](#1567) [`070430166`](0704301) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Add a reducer action for removing unlimited points - [#1573](#1573) [`50c1b19e5`](50c1b19) Thanks [@benchristel](https://github.com/benchristel)! - Internal: fix incorrect comment - Updated dependencies \[[`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#1534](#1534) [`d446d4251`](d446d42) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove 'strings' prop from ContentPreview (we'll pull it from context) ### Patch Changes - [#1552](#1552) [`873f10790`](873f107) Thanks [@nishasy](https://github.com/nishasy)! - Update dependency on wonder-blocks-form - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp - [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom. - [#1534](#1534) [`d446d4251`](d446d42) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Ensure 'React' is imported in ContentPreview component. - Updated dependencies \[[`efced74db`](efced74), [`873f10790`](873f107), [`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e), [`598f7450f`](598f745), [`070430166`](0704301), [`50c1b19e5`](50c1b19)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp ## @khanacademy/[email protected] ### Patch Changes - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp - [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom. - Updated dependencies \[[`40d0b67a8`](40d0b67)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`40d0b67a8`](40d0b67)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp ## @khanacademy/[email protected] ### Patch Changes - [#1569](#1569) [`40d0b67a8`](40d0b67) Thanks [@handeyeco](https://github.com/handeyeco)! - bump peer dependencies to match webapp - [#1548](#1548) [`21a908e8f`](21a908e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing resizing behavior of Expression Widget in 400% zoom. - Updated dependencies \[[`40d0b67a8`](40d0b67), [`21a908e8f`](21a908e)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1562
Summary:
Enabling rootBoundary mode for Popover implementation in Expression Widget. This ensures the popover container does not snap depending on the viewport and instead positions it's contend based on where there is room in the page document. This change is needed an intended to ensure the Expression Widget is accessible to users in 400% or very small screen sizes.
Issue: LEMS-2085
Test plan: