-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Interactive Graph: Circle] Add a key prop to the circle drag handle #1388
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (048a47b) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1388 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1388 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is because the six dots in the drag handle are generated from coordinates. Thanks for the fix!
Size Change: +24 B (0%) Total Size: 849 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 69.79% 70.85% +1.06%
==========================================
Files 493 497 +4
Lines 104304 104388 +84
Branches 5293 11276 +5983
==========================================
+ Hits 72794 73962 +1168
+ Misses 31394 30426 -968
+ Partials 116 0 -116
... and 127 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1386](#1386) [`5fdbeb980`](5fdbeb9) Thanks [@benchristel](https://github.com/benchristel)! - Add `mafs.point` flag to ApiOptions type ### Patch Changes - [#1388](#1388) [`94067d752`](94067d7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Circle] Add a key prop to the circle drag handle ## @khanacademy/[email protected] ### Patch Changes - [#1385](#1385) [`30f898c44`](30f898c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Remove the use of graphKey for remounting - Updated dependencies \[[`5fdbeb980`](5fdbeb9), [`94067d752`](94067d7)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1387
Summary:
There's always a console error saying that the circle graph drag handle
is missing the
key
prop.Adding a
key
here.Issue: none
Test plan:
Open the console and make sure the error isn't showing up anymore.
yarn jest packages/perseus/src/widgets/__tests__/interactive-graph.test.ts
Make sure the logs don't show the console error anymore.