Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph: Circle] Add a key prop to the circle drag handle #1388

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Jul 1, 2024

Summary:

There's always a console error saying that the circle graph drag handle
is missing the key prop.

Adding a key here.

Issue: none

Test plan:

Open the console and make sure the error isn't showing up anymore.

yarn jest packages/perseus/src/widgets/__tests__/interactive-graph.test.ts
Make sure the logs don't show the console error anymore.

Screenshot 2024-07-01 at 3 10 31 PM

@nishasy nishasy self-assigned this Jul 1, 2024
@nishasy nishasy requested review from benchristel and a team July 1, 2024 22:10
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/sour-cougars-draw.md, packages/perseus/src/widgets/interactive-graphs/graphs/circle.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (048a47b) and published it to npm. You
can install it using the tag PR1388.

Example:

yarn add @khanacademy/perseus@PR1388

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1388

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is because the six dots in the drag handle are generated from coordinates. Thanks for the fix!

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Size Change: +24 B (0%)

Total Size: 849 kB

Filename Size Change
packages/perseus/dist/es/index.js 410 kB +24 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-editor/dist/es/index.js 272 kB
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (30f898c) to head (048a47b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   69.79%   70.85%   +1.06%     
==========================================
  Files         493      497       +4     
  Lines      104304   104388      +84     
  Branches     5293    11276    +5983     
==========================================
+ Hits        72794    73962    +1168     
+ Misses      31394    30426     -968     
+ Partials      116        0     -116     

Impacted file tree graph

Files Coverage Δ
...s/src/widgets/interactive-graphs/graphs/circle.tsx 98.46% <100.00%> (+0.01%) ⬆️

... and 127 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f898c...048a47b. Read the comment docs.

@nishasy nishasy merged commit 94067d7 into main Jul 1, 2024
12 of 19 checks passed
@nishasy nishasy deleted the circle-key branch July 1, 2024 22:20
benchristel pushed a commit that referenced this pull request Jul 2, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/[email protected]

### Minor Changes

-   [#1386](#1386) [`5fdbeb980`](5fdbeb9) Thanks [@benchristel](https://github.com/benchristel)! - Add `mafs.point` flag to ApiOptions type

### Patch Changes

-   [#1388](#1388) [`94067d752`](94067d7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Circle] Add a key prop to the circle drag handle

## @khanacademy/[email protected]

### Patch Changes

-   [#1385](#1385) [`30f898c44`](30f898c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Remove the use of graphKey for remounting

-   Updated dependencies \[[`5fdbeb980`](5fdbeb9), [`94067d752`](94067d7)]:
    -   @khanacademy/[email protected]

Author: khan-actions-bot

Reviewers: benchristel

Required Reviewers:

Approved By: benchristel

Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️  Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants