Add mafs.point flag to Renderer prop types
#1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perseus renders point graphs with fixed numbers of points using Mafs when the `mafs.point` flag is on. Previously, however, the apiOptions type (used in the Renderer props) did not allow this flag to be passed. This commit makes it so the flag can be passed without a type error.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (dc43a36) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1386If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1386 |
|
Size Change: 0 B Total Size: 849 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
+ Coverage 69.82% 71.01% +1.18%
==========================================
Files 493 497 +4
Lines 104323 104406 +83
Branches 7522 10631 +3109
==========================================
+ Hits 72842 74141 +1299
+ Misses 31301 30265 -1036
+ Partials 180 0 -180 see 142 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
nishasy
approved these changes
Jul 1, 2024
Merged
benchristel
pushed a commit
that referenced
this pull request
Jul 2, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1386](#1386) [`5fdbeb980`](5fdbeb9) Thanks [@benchristel](https://github.com/benchristel)! - Add `mafs.point` flag to ApiOptions type ### Patch Changes - [#1388](#1388) [`94067d752`](94067d7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph: Circle] Add a key prop to the circle drag handle ## @khanacademy/[email protected] ### Patch Changes - [#1385](#1385) [`30f898c44`](30f898c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Remove the use of graphKey for remounting - Updated dependencies \[[`5fdbeb980`](5fdbeb9), [`94067d752`](94067d7)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Perseus renders point graphs with fixed numbers of points using Mafs
when the
mafs.pointflag is on. Previously, however, the apiOptionstype (used in the Renderer props) did not allow this flag to be passed.
This commit makes it so the flag can be passed without a type error.
Issue: none
Test plan: