Make graph specific properties persist and display on preview graph #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function builds the graph key based on the "correct" object
|
Size Change: +89 B (+0.01%) Total Size: 845 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 69.77% 70.96% +1.18%
==========================================
Files 488 492 +4
Lines 103276 103365 +89
Branches 7430 11200 +3770
==========================================
+ Hits 72058 73349 +1291
+ Misses 31039 30016 -1023
+ Partials 179 0 -179
... and 142 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Myranae
requested review from
SonicScrewdriver,
handeyeco and
a team
and removed request for
a team
Merged
nishasy
added a commit
that referenced
this pull request
Jun 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1348](#1348) [`73ba4f7c9`](73ba4f7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Update the locked ellipse settings so they only take degrees as input. - [#1353](#1353) [`e528c5b2b`](e528c5b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] View a locked polygon - [#1351](#1351) [`9a6517ca2`](9a6517c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add blue and gold to locked figures colorset ### Patch Changes - [#1350](#1350) [`1e877c6d4`](1e877c6) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add locked vector to storybook story for all locked figures - [#1345](#1345) [`92990f15f`](92990f1) Thanks [@benchristel](https://github.com/benchristel)! - Fix a bug in the exercise editor where the preview did not update after a change to the graph type or number of line segments. ## @khanacademy/[email protected] ### Minor Changes - [#1348](#1348) [`73ba4f7c9`](73ba4f7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Update the locked ellipse settings so they only take degrees as input. - [#1353](#1353) [`e528c5b2b`](e528c5b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] View a locked polygon - [#1351](#1351) [`9a6517ca2`](9a6517c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add blue and gold to locked figures colorset - [#1354](#1354) [`e73373f48`](e73373f) Thanks [@Myranae](https://github.com/Myranae)! - Fix interactive graph editor in storybook to display and persist options ### Patch Changes - [#1350](#1350) [`1e877c6d4`](1e877c6) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add locked vector to storybook story for all locked figures - Updated dependencies \[[`1e877c6d4`](1e877c6), [`92990f15f`](92990f1), [`73ba4f7c9`](73ba4f7), [`e528c5b2b`](e528c5b), [`9a6517ca2`](9a6517c)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, graph specific properties, like number of sides and snapTo type for polygons, did not appear in the preview graph and did not persist or actually affect the preview graph. This makes it so the options selected affect the preview graph.
Issue: LEMS-2093
Test plan: