[Interactive Graph Editor] Add blue and gold back as colors for locked figures #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only take degrees for the angle input We had it so that locked ellipse settings allow for either degrees or radians for the angel input. However, I realized that we're not saving the data for what unit is being used. This means that if an angle were saved as "30 degrees" and then the page were reloaded, it would then show up as "0.523599 radians". For the sake of simplicty and consistency, I'm changing this so that it only takes degrees, and I'm changing it to a number input since it no longer needs to evaluate expressions with pi (that required it being a text input). Issue: https://khanacademy.atlassian.net/browse/LEMS-1941 Test plan: `yarn jest` Storybook - http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag - Confirm that the ellipse settings angle input shows degrees only - Confirm that it is rotated correctly
…ll locked figures Super minor. Just adding a locked vector to the `segmentWithLockedFigures` testdata so that the stories with all locked figures show all the current locked figures. Issue: none Test plan: http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag confirm all four locked figure types' settings are there
…d figures At the moment, we only allow authors to use 5 colors for interactive graph locked figures. However, there was a request to add blue and gold to the colorset. - Adding blue and orange (formerly gold) to the colorset Issue: none Test plan: - http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag - Confirm that blue and gold are present in the color dropdowns - there should be 7 total colors
|
Size Change: +38 B (0%) Total Size: 845 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
+ Coverage 69.63% 71.14% +1.50%
==========================================
Files 488 492 +4
Lines 103250 103307 +57
Branches 7437 10509 +3072
==========================================
+ Hits 71902 73499 +1597
+ Misses 31166 29808 -1358
+ Partials 182 0 -182
... and 144 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (019a47a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1351If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1351 |
Myranae
approved these changes
Jun 17, 2024
| "red", | ||
| ] as const; | ||
|
|
||
| export type LockedFigureColor = (typeof lockedFigureColorNames)[number]; | ||
|
|
||
| export const lockedFigureColors: Record<LockedFigureColor, string> = { | ||
| blue: "#3D7586", |
There was a problem hiding this comment.
Question: Are these the same as the WB color tokens? Just curious :)
There was a problem hiding this comment.
Nope! They're MathJax colors.
mark-fitzgerald
approved these changes
Jun 17, 2024
|
The parent pull-request (#1350) has been merged into |
Merged
nishasy
added a commit
that referenced
this pull request
Jun 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1348](#1348) [`73ba4f7c9`](73ba4f7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Update the locked ellipse settings so they only take degrees as input. - [#1353](#1353) [`e528c5b2b`](e528c5b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] View a locked polygon - [#1351](#1351) [`9a6517ca2`](9a6517c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add blue and gold to locked figures colorset ### Patch Changes - [#1350](#1350) [`1e877c6d4`](1e877c6) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add locked vector to storybook story for all locked figures - [#1345](#1345) [`92990f15f`](92990f1) Thanks [@benchristel](https://github.com/benchristel)! - Fix a bug in the exercise editor where the preview did not update after a change to the graph type or number of line segments. ## @khanacademy/[email protected] ### Minor Changes - [#1348](#1348) [`73ba4f7c9`](73ba4f7) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Update the locked ellipse settings so they only take degrees as input. - [#1353](#1353) [`e528c5b2b`](e528c5b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] View a locked polygon - [#1351](#1351) [`9a6517ca2`](9a6517c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add blue and gold to locked figures colorset - [#1354](#1354) [`e73373f48`](e73373f) Thanks [@Myranae](https://github.com/Myranae)! - Fix interactive graph editor in storybook to display and persist options ### Patch Changes - [#1350](#1350) [`1e877c6d4`](1e877c6) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add locked vector to storybook story for all locked figures - Updated dependencies \[[`1e877c6d4`](1e877c6), [`92990f15f`](92990f1), [`73ba4f7c9`](73ba4f7), [`e528c5b2b`](e528c5b), [`9a6517ca2`](9a6517c)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
At the moment, we only allow authors to use 5 colors for interactive graph
locked figures. However, there was a request to add blue and gold to the colorset.
Note that these colors were part of the original colorset. They were removed in the following commit:
2d3c3b4#diff-5737e5c75b244a64356894bb42c711539f1589cfbd9dcbbd4b22a3db8773d524
Issue: none
Test plan: