Upgrade golangci-lint #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.42 seems to be having some problems with Go 1.18 (see #2649), so let's just upgrade to latest. There was one new error, suggesting to use `%q` rather than `"%s"`, since the former does escapes properly. It doesn't really matter for us -- the string should be an identifier -- but it doesn't hurt. (Plus it wanted us to upgrade from ioutil, which I did in #181.) Test plan: make check
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
StevenACoffman
approved these changes
Mar 22, 2022
csilvers
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.42 seems to be having some problems with Go 1.18 (see #2649), so let's
just upgrade to latest. There was one new error, suggesting to use
%qrather than
"%s", since the former does escapes properly. It doesn'treally matter for us -- the string should be an identifier -- but it
doesn't hurt. (Plus it wanted us to upgrade from ioutil, which I did
in #181.)
Test plan: make check
I have: