Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ioutil #181

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Remove ioutil #181

merged 1 commit into from
Mar 22, 2022

Conversation

benjaminjkraft
Copy link
Collaborator

In 1.16, it's now deprecated and replaced by io and os. Let's
upgrade!

Test plan:

  • make check
  • git grep ioutil

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@benjaminjkraft
Remove ioutil
c1cc71c 
In 1.16, it's now deprecated and replaced by `io` and `os`.  Let's
upgrade!

Test plan:
- make check
- git grep ioutil
csilvers
csilvers approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@benjaminjkraft benjaminjkraft merged commit 000f311 into main Mar 22, 2022
@benjaminjkraft benjaminjkraft deleted the benkraft.ioutil branch March 22, 2022 19:10
benjaminjkraft added a commit that referenced this pull request Mar 22, 2022
@benjaminjkraft
Upgrade golangci-lint
74773f3 
1.42 seems to be having some problems with Go 1.18 (see #2649), so let's
just upgrade to latest.  There was one new error, suggesting to use `%q`
rather than `"%s"`, since the former does escapes properly.  It doesn't
really matter for us -- the string should be an identifier -- but it
doesn't hurt.  (Plus it wanted us to upgrade from ioutil, which I did
in #181.)

Test plan: make check
@benjaminjkraft benjaminjkraft mentioned this pull request Mar 22, 2022
Merged
6 tasks
benjaminjkraft added a commit that referenced this pull request Mar 22, 2022
@benjaminjkraft
Upgrade golangci-lint (#182)
e81d19c 
1.42 seems to be having some problems with Go 1.18 (see #2649), so let's
just upgrade to latest.  There was one new error, suggesting to use `%q`
rather than `"%s"`, since the former does escapes properly.  It doesn't
really matter for us -- the string should be an identifier -- but it
doesn't hurt.  (Plus it wanted us to upgrade from ioutil, which I did
in #181.)

Test plan: make check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csilvers csilvers csilvers approved these changes

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminjkraft @csilvers