Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs/index): overflow issue in install command #1095

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tometo-dev
Copy link
Contributor

@tometo-dev tometo-dev commented Apr 14, 2024

There seems to be an overflow issue for the code-block for install commands.

I didn't know if it was okay to directly change the <Highlight > component in the <SampleCodeSnippet> component, so added an extra optional prop to extend the sx prop of the <Paper> component.

Original (material-react-table.com):
image

After fix:
image

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 11:43am
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 11:43am

@KevinVandy KevinVandy merged commit 4eade9d into KevinVandy:v2 Apr 18, 2024
2 checks passed
RubiCom001 added a commit to RubiCom001/material-react-table that referenced this pull request Apr 20, 2024
commit 85b98f9
Author: KevinVandy <[email protected]>
Date:   Thu Apr 18 21:02:31 2024 +0000

    Upgrade Examples

commit f8dc5d8
Author: Kevin Vandy <[email protected]>
Date:   Thu Apr 18 14:54:55 2024 -0600

    release v2.13.0

commit c47471b
Author: Kosmas Sidiropoulos <[email protected]>
Date:   Thu Apr 18 21:03:41 2024 +0100

    Added Greek language support (KevinVandy#1106)

commit fea94c9
Author: Kevin Vandy <[email protected]>
Date:   Thu Apr 18 13:58:45 2024 -0600

    remove +1 on modal calc

commit c60afb0
Author: helt <[email protected]>
Date:   Thu Apr 18 21:57:30 2024 +0200

    Fixed theme index in fullscreen mode (KevinVandy#1048)

    Co-authored-by: Hendrik Lücke-Tieke <[email protected]>

commit 4eade9d
Author: Sudhanshu <[email protected]>
Date:   Fri Apr 19 01:25:25 2024 +0530

    fix(docs/index): overflow issue in install command (KevinVandy#1095)

commit 7aa7799
Author: Marek Patyna <[email protected]>
Date:   Thu Apr 18 21:54:31 2024 +0200

    Update pl.ts (KevinVandy#1089)

    rekordów => wyników

commit b33f4c4
Author: KevinVandy <[email protected]>
Date:   Thu Apr 18 03:22:16 2024 +0000

    Upgrade Examples

commit e51d15b
Author: Kevin Vandy <[email protected]>
Date:   Wed Apr 17 21:13:15 2024 -0600

    package upgrades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants