Fixed theme index in fullscreen mode #1048
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Do tooltips still work? |
|
If you mean the tooltips for e.g. the sorting button, then yes. In normal view and also in fullscreen
|
| @@ -58,7 +61,7 @@ export const MRT_TablePaper = <TData extends MRT_RowData>({ | |||
| right: 0, | |||
| top: 0, | |||
| width: '100dvw', | |||
| zIndex: 999, | |||
| zIndex: theme.zIndex.modal + 1, | |||
There was a problem hiding this comment.
@helt, please don't add "+1" to theme.zIndex.modal. This will cause, other modal and dialog components to appear below MRT_TablePaper
There was a problem hiding this comment.
@sadik-malik Whats your suggestion to use then? Plain theme.zIndex.modal ?
There was a problem hiding this comment.
yes, if it is not breaking any of the test cases.
There was a problem hiding this comment.
https://stackblitz.com/edit/github-morytr-zqdrka?file=src%2Fexample.tsx
@helt, In the above stackblitz example you can see Dialog component is appearing below MRT_TablePaper when zIndex is set to theme.zIndex.modal + 1
There was a problem hiding this comment.
so this should work perfectly fine as long as no + 1 is added?
commit 85b98f9 Author: KevinVandy <[email protected]> Date: Thu Apr 18 21:02:31 2024 +0000 Upgrade Examples commit f8dc5d8 Author: Kevin Vandy <[email protected]> Date: Thu Apr 18 14:54:55 2024 -0600 release v2.13.0 commit c47471b Author: Kosmas Sidiropoulos <[email protected]> Date: Thu Apr 18 21:03:41 2024 +0100 Added Greek language support (KevinVandy#1106) commit fea94c9 Author: Kevin Vandy <[email protected]> Date: Thu Apr 18 13:58:45 2024 -0600 remove +1 on modal calc commit c60afb0 Author: helt <[email protected]> Date: Thu Apr 18 21:57:30 2024 +0200 Fixed theme index in fullscreen mode (KevinVandy#1048) Co-authored-by: Hendrik Lücke-Tieke <[email protected]> commit 4eade9d Author: Sudhanshu <[email protected]> Date: Fri Apr 19 01:25:25 2024 +0530 fix(docs/index): overflow issue in install command (KevinVandy#1095) commit 7aa7799 Author: Marek Patyna <[email protected]> Date: Thu Apr 18 21:54:31 2024 +0200 Update pl.ts (KevinVandy#1089) rekordów => wyników commit b33f4c4 Author: KevinVandy <[email protected]> Date: Thu Apr 18 03:22:16 2024 +0000 Upgrade Examples commit e51d15b Author: Kevin Vandy <[email protected]> Date: Wed Apr 17 21:13:15 2024 -0600 package upgrades
Fixes #1039
@KevinVandy Is using the theme here okay?