JSON comments rework #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BL9 worldgen locations: since those are still unused and are part of future "secret expansion" I've changed their weight generation to zero so they don't spam into debug log every time. Engineering Essentials: removed unnecessary separator in plasma_slug relatives; this one is critical. Made little change for electric pump mod: removed it's acceptability for airspeargun, since this thing is for underwater use and shouldn't be used with electrical things (and it doesn't have mechanism slots anyway) Fuji Structures: added zero weight generation for house template for it not to shown up in debug log. Modern Weapon Pack: removed .38 ammo type from compatible ammo list for automag. This is leftover from previous Issue #6 which I will close now. PK's Rebalancing: replaced BFG field type effect from fd_rubble to fd_plasma since fd_rubble is obsolete since Cataclysm-BN release 1101, and it's more fitting for the BFG! Also removed launchers from mod targets for underbarrel bomblet launcher, because there are no slots, and you probably shouldn't attach launcher onto your launcher.
…ts-Kenan-Mod-Pack" This reverts commit 72d9ab5, reversing changes made to 4db38ae.
S&W 629 tried to be loaded with .45 ACP instead of something of .44 and produced error on selecting Bionic Gunslinger profession.
Merged mechanics of Automations mod, marking it as depreciated.
Formatting and adding some additional info
Gyrocopter BN adaptation and removing used chalice as obsolete item.
|
@CV514 Awesome work as usually, thank you for the effort you put into our project :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to load ALL the mods at once and debugged them until no more commentary errors popped up. Some comments could use a little better formatting, too, but at least they will not break anything for now.
Game even managed to load!
I'd say there is still much to do considering other errors; I've tried to fix some of them that prevented game load at all.
And little fixes here and there about unimplemented ammo and action types in Bright Nights fork. Nothing big.
I may have missed something or there may be some ongoing commit in development, but if anything's good, issue #16 can go to sleep.