Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON duplicate comment keys rework #16

Closed
vorpal-void opened this issue Jan 26, 2021 · 1 comment
Closed

JSON duplicate comment keys rework #16

vorpal-void opened this issue Jan 26, 2021 · 1 comment

Comments

@vorpal-void
Copy link
Contributor

According to https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/JSON_INFO.md

If we want multiple comments in a single object then append a number to //. For example:

{
  "//" : "comment",
  "//1" : "another comment",
  "//2" : "yet another comment"
}

And since CleverRaven/Cataclysm-DDA#40390 (BN: cataclysmbnteam/Cataclysm-BN#324)

We're in the works of fixin'! Yay

For examle, Secronom:

Error: data/mods//secronom/Modification Files/Items/secro_guns.json: line 266:14: duplicate entry in json object

        "volume": "2500 ml",
        "price": 2144000,
        "//":
             ^
              "Didn't see a price for this.",
        "to_hit": -1,
        "bashing": 12,

I'm opening this up as a milestone issue.

@Kenan2000
Copy link
Owner

This has been fixed a while ago too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants