Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-276] Wrap graph algorithms for Python #177

Merged
merged 6 commits into from
Apr 29, 2021

Conversation

arthurp
Copy link
Contributor

@arthurp arthurp commented Apr 22, 2021

No description provided.

@arthurp arthurp requested a review from gurbinder533 April 22, 2021 23:07
@arthurp arthurp force-pushed the feature/wrap-algorithms branch from f6a9c07 to 0c9f279 Compare April 25, 2021 22:59
@arthurp arthurp marked this pull request as ready for review April 25, 2021 23:02
@arthurp arthurp force-pushed the feature/wrap-algorithms branch 3 times, most recently from 86b0d09 to 8f79211 Compare April 27, 2021 17:41
@arthurp arthurp changed the title Wrap graph algorithms for Python [ENG-276] Wrap graph algorithms for Python Apr 27, 2021
Copy link
Contributor

@gurbinder533 gurbinder533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for the comments on C++ apps. Will get to those soon.

arthurp added 6 commits April 28, 2021 20:20
This enables the use of std collections of TemporaryPropertyGuards
* Avoid leaking properties in the error case.
* Create output in the correct graph
* Improve docs
* Was reordering edges passed in.
* Wasn't correctly generating CSR.
* Was using source graph edge IDs instead of output edge IDs.
local_clustering_coefficient, louvain_clustering,
subgraph_extraction

The tests are insufficient and need work.
@arthurp arthurp force-pushed the feature/wrap-algorithms branch from 8f79211 to 9896484 Compare April 29, 2021 01:20
@arthurp arthurp merged commit 0bce055 into KatanaGraph:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants