-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up libgalois algorithms and add TODOs for notable issues. #171
Conversation
// TODO(amp): This is incorrect. For Node2vec this needs to be: | ||
// Algorithm::Graph::Make(pg, {}, {}) // Ignoring all properties. | ||
// For Edge2vec this needs to be: | ||
// Algorithm::Graph::Make(pg, {}, {edge_type_property_name}) | ||
// The current version requires the input to have exactly the properties | ||
// expected by the algorithm implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue needs to be addressed to wrap RandomWalks
. The algorithm will currently not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. We need to separate them out into different applications.
There are a couple of smaller issues that I would like to address before wrapping: katana/libgalois/include/katana/analytics/subgraph_extraction/subgraph_extraction.h Lines 29 to 35 in e62ff06
katana/libgalois/include/katana/analytics/random_walks/random_walks.h Lines 75 to 80 in e62ff06
I can convert all these into Github and/or JIRA issues if that's better for you. This was just a convenient way to communicate this for me at the moment. |
e62ff06
to
05e9bb0
Compare
There are other TODOs in this PR, but they are mostly documentation issues, so they do not directly affect wrapping. |
05e9bb0
to
e9a96f7
Compare
Closing this in favor of #177. This commit is in that PR and some of the issues are addressed there in one way or another. |
No description provided.