Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[substrait] Substrait to Velox class, change private to protected. #6

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[substrait] Substrait to Velox class, change private to protected. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion velox/substrait/SubstraitToVeloxExpr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SubstraitVeloxExprConverter {
const ::substrait::Expression::IfThen& substraitIfThen,
const RowTypePtr& inputType);

private:
protected:
/// Convert list literal to ArrayVector.
ArrayVectorPtr literalsToArrayVector(
const ::substrait::Expression::Literal& listLiteral);
Expand Down
2 changes: 1 addition & 1 deletion velox/substrait/SubstraitToVeloxPlan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class SubstraitVeloxPlanConverter {
const ::substrait::RelCommon& relCommon,
const core::PlanNodePtr& noEmitNode);

private:
protected:
/// Returns unique ID to use for plan node. Produces sequential numbers
/// starting from zero.
std::string nextPlanNodeId();
Expand Down
Loading