Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[substrait] Substrait to Velox class, change private to protected. #6

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[substrait] Substrait to Velox class, change private to protected. #6

merged 1 commit into from
Feb 23, 2024

Conversation

howarlii
Copy link

@howarlii howarlii commented Feb 23, 2024 •
edited
Loading

继承velox的SubstraitVeloxPlanConverter开发Flavius的SubstraitVeloxPlanConverter，需要将velox对象中的private:改为protected:使得flavius能够访问其内部的成员方法。

@yaobaiwei yaobaiwei merged commit 0cbee6c into Kasma-Inc:main Feb 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lych4o lych4o lych4o approved these changes

@TatianaJin TatianaJin TatianaJin approved these changes

@yaobaiwei yaobaiwei yaobaiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howarlii @yaobaiwei @TatianaJin @lych4o