Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): Add missing ReloadProvider #1219

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(vscode): Add missing ReloadProvider #1219

merged 1 commit into from
Jul 2, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jun 28, 2024 •
edited
Loading

Relates to: #1211 (comment)

@lordrip lordrip requested a review from apupier June 28, 2024 19:17
@lordrip lordrip mentioned this pull request Jun 28, 2024
Merged
@apupier
Copy link
Member

apupier commented Jun 28, 2024

Relates to: #1219

it relates to itself ;-)

@lordrip
Copy link
Member Author

lordrip commented Jun 28, 2024

Relates to: #1219

it relates to itself ;-)

I guess yes 🤦

apupier
apupier approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit more changes required to have updated values in all cases for catalogUrl but required only with VS Code and so implemented in the PR specific to it

@apupier apupier merged commit 5a8598c into KaotoIO:main Jul 2, 2024
9 checks passed
@lordrip lordrip deleted the fix/add-missing-provider branch July 2, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apupier apupier apupier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lordrip @apupier