-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pick settings from multiplying architecture at init #1211
Feat/pick settings from multiplying architecture at init #1211
Conversation
671b29d
to
a5fc901
Compare
now it can load the one specified in settings To do:
there is another error before on runtime.provider.tsx l.36:
so means the props.catalogUrl at this place is not picking the one from the rootcomponent, or picking it before and i guess we are back to the need to use React context that i wasn't able to use . |
@lordrip any hints what is the correct way to proceed so that the catalogUrl is set/updated in a correct way for React? |
00d604f
to
5bbfa6d
Compare
There is currently quite a mix between passing the catalogURL through properties on the React component and using the settingsManager. I failed to use just one or the other in a good way so far. Given current constraints on timeline and ressources, I propose to go with current state and work to improve that later. Reported #1227 for that. |
In combination with #1227 , it gives: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it restoring the runtime.provider.tsx
file and it works good in both VSCode and the online version.
5bbfa6d
to
8a1ccfb
Compare
url part of KaotoIO#1204 Signed-off-by: Aurélien Pupier <[email protected]>
8a1ccfb
to
453d456
Compare
currently error in console.log: