[DO NOT MERGE] feat: 1.9.0 release #460

ntn-x2 · 2023-02-01T10:22:08Z

Fixes https://github.com/KILTprotocol/ticket/issues/2396.

PR shows the diff with the master branch.

For better insights into what this release changes, please refer to the diff with develop - to see if we included all the latest features and fixes - and the diff with 1.8.0 to check exactly what we have changed

Edit

After going through past releases and other chain upgrade paths, I found out two migrations we did not consider:

Scheduler: remove empty agenda on cancel paritytech/substrate#12989: no biggie for us, it is just executed after the v3 migration for the same pallet
API for registering inactive funds paritytech/substrate#12813: this is a tricky one. We should run the migration since we need to bump the storage version of the pallet and also because the treasury starts tracking deactivated funds anyway. All the other chains I've seen, they use the XCM checking account as the account in the migration (which deactivates funds on check_out and reactivates them on check_in). We do not have that, and beyond the treasury have nothing else to be considered as inactive. Apparently Polkadot does not consider deposits as inactive. We could consider removing the tokens sent to the pure proxy as deactivated, perhaps in the next migration. It is not critical that we do it in the same migration.

TODO

Review
Benchmarks

## fixes [KILTProtocol/ticket#2255](https://github.com/KILTprotocol/ticket/issues/2255)

This reverts commit 0d0044b.

This reverts commit c8f4577.

we test first on peregrine and will later enable this feature on spiritnet

This reverts commit df5abe3.

This reverts commit 6d4fcc6.

Since rust-analyzer has been merged into the main rustlang repo, it is tested for breaking changes. This means that we don't need to pin the nightly to a specific version anymore, as using the latest nightly is always guaranteed to work with the latest version of the rust-analyzer extension (try it yourselves, for me it finally just works). This PR then does the following: - update the toolchain file to use the latest nightly, which gives us access to potentially new clippy warnings, and to better rust-analyzer performances - update the runtime builder to use Rust 1.64 as also nowadays done by Polkadot - remove the deprecated `cargo-features = ["workspace-inheritance"]`, since from 1.64 it has been stabilised (this could be caught only by using a recent enough nightly version) - Let the CI job use the same version as in the toolchain file, by removing the `+nightly` flag. This will ensure we have a consistent behaviour between local machine and CI server. The only thing to consider is that the nightly will differ from the version that srtool uses to build the runtime WASM. That was the case also before, and it will always be until substrate will support compilation with the stable toolchain.

## fixes KILTProtocol/ticket#2289 and KILTProtocol/ticket#2296 * Upgrades from Polkadot v0.9.29 to v0.9.32 * Adds missing feature implementations for all tomls (checked via `subalfred check features` in all crates) * Actually necessary for application of paritytech/substrate#10592 (see runtime changes in [dd81eac](dd81eac)) * Migrates Democracy, Preimage and Scheduler pallets to use bounded Calls, see below ## Summary of changes (Polkadot v0.9.30-0.9.32) * Weights v2 are not fully there yet, but the struct now includes the [second field for storage size](paritytech/substrate#12277) (tracking issue: https://github.com/paritytech/substrate/issues/12176) ### Breaking Changes * Breaking: Outer enums (paritytech/substrate#11981) * `Origin` --> `RuntimeOrigin` * `Call` --> `RuntimeCall` * `Event` --> `RuntimeEvent` * ~Convention seems to be to keep `Event`, `Call`, `Origin` for inner pallet usage, e.g. `Did::Origin`~ Update: We use `Runtime` prefix internally as well ### Noteworthy PRs * paritytech/substrate#12109 * paritytech/substrate#12328 * paritytech/cumulus#1585 * Following the effort of decoupling collators and full relay nodes, this PR adds the possibility of pointing the collator to an “external” (non in-process) relay node. This is still considered experimental, and the **relay node is suggested to run on the same machine than the collator for the moment**. * To specify the relay full node rpc: `polkadot-parachain --alice --collator --relay-chain-rpc-url <rpc-websocket-url>` * paritytech/substrate#12486 * Before this change only the interpreted WASM executor was included in per default compilations. Making the compiled executor opt-in, now, compiled WASM executor is set by default and an opt-out instead. This could lead to **big performance difference** between using these two, as more recent versions of the interpreter see a regression in performance. ### Scheduler, Preimage, Democracy Migration * paritytech/substrate#11649 * Referenda, Democracy, Scheduler and Preimage pallets are all now bounded in storage access footprint * Removed the concept of a "hard deadline" or weight-override priority and no longer guarantees that at least one scheduled item will be executed per block (since these are both dangerous to parachains which have a strict need of weight limits). This means you must ensure that scheduled items are below the MaximumWeight or they will not be executed. * Interesting comment: paritytech/substrate#11649 (comment) > There is migration code which moves existing proposals and referenda over to the new format. However IT DOES NOT MIGRATE EVERYTHING: > > * Preimages are **NOT** migrated. Any registered preimages in Democracy at the time of migration are dropped. Their balance is **NOT UNRESERVED**. > * The re-dispatcher used in the old Democracy implementation is removed. Any proposals scheduled for dispatch by Democracy **WILL NOT EXECUTE**. > > This means you SHOULD ensure that: > > * **the preimage for the runtime upgrade is placed as an imminent preimage, not with a deposit;** > * **no other preimages are in place at the time of upgrade;** > * **there are no other proposals scheduled for dispatch by Democracy at the time of upgrade.** > > The Democracy pallet will be marked as deprecated immediately once Referenda is considered production-ready. **ALL TEAMS ARE RECOMMENDED TO SWITCH SWAY FROM DEMOCRACY PALLET TO REFERENDA/CONVICTION-VOTING PALLETS ASAP** #### Result of `try-runtime` against Spiritnet on Friday Nov 18, 2022: ``` 2022-11-18 09:27:23.917 INFO main runtime::preimage::migration::v1: Migrating 0 images 2022-11-18 09:27:23.917 INFO main runtime::scheduler::migration: Trying to migrate 0 agendas... 2022-11-18 09:27:23.917 INFO main runtime::scheduler::migration: Migrated 0 agendas. 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: 0 public proposals will be migrated. 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: 25 referenda will be migrated. 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #7 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #20 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #13 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #5 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #8 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #1 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #19 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #9 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #16 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #14 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #21 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #15 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #24 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #22 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #2 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #10 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #0 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #6 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #11 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #3 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #17 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #18 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #23 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #4 2022-11-18 09:27:23.917 INFO main runtime::democracy::migration::v1: migrating referendum #25 2022-11-18 09:27:23.918 INFO main runtime::democracy::migration::v1: 0 public proposals migrated, 25 referenda migrated ``` ## Checklist: - [x] I have verified that the code works - [x] No panics! (checked arithmetic ops, no indexing `array[3]` use `get(3)`, ...) - [x] I have verified that the code is easy to understand - [ ] If not, I have left a well-balanced amount of inline comments - [x] I have [left the code in a better state](https://deviq.com/principles/boy-scout-rule) - [x] I have documented the changes (where applicable)

## fixes NO TICKET

New Relaychain spec, code substitute for peregrine Co-authored-by: William Freudenberger <[email protected]>

## related https://github.com/KILTprotocol/ticket/issues/2356 ## Checklist: - [ ] I have verified that the code works - [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use `get(3)`, ...) - [ ] I have verified that the code is easy to understand - [ ] If not, I have left a well-balanced amount of inline comments - [ ] I have [left the code in a better state](https://deviq.com/principles/boy-scout-rule) - [ ] I have documented the changes (where applicable)

## fixes https://github.com/KILTprotocol/ticket/issues/2387

After the move to Polkadot, Spiritnet XCM config was still referring to Kusama as the relay chain. This should be updated now. Co-authored-by: Albrecht <[email protected]>

## fixes KILTProtocol/ticket#2351 Upgrade polkadot version to 0.9.36 ### Notable changes in 0.9.32 -> 0.9.33 [Full changelog](https://github.com/paritytech/polkadot/releases/tag/v0.9.33) This release is super small and only consists of removing the sp_tasks::spawn api, that wasn't used by us or any others (paritytech/substrate#12639). The only other change was an internal refactoring of the state database in paritytech/substrate#12239 ### Notable changes in 0.9.33 -> 0.9.34 [Full changelog](https://github.com/paritytech/polkadot/releases/tag/v0.9.34) This is a bigger runtime only release mainly about improvements to opengov and collectives. The only notable change that required code changes was the removal of the wasmtime feature flag in some crates paritytech/substrate#12684 ### Notable changes in 0.9.34 -> 0.9.35 [Full changelog](https://github.com/paritytech/polkadot/releases/tag/v0.9.35) Most notable are the two changes paritytech/substrate#12891 and paritytech/substrate#12868. Also there is now the possibility to use a new RPC server that supports http and websocket requests on the same server. We should look into this since this will eventually cause the older severs to be deprecated in the future (paritytech/substrate#12663). In paritytech/substrate#12485 a general message queue pallet was introduced that might be helpful for receivng XCM in the future. ### Notable changes in 0.9.35 -> 0.9.36 [Full changelog](https://github.com/paritytech/polkadot/releases/tag/v0.9.36) This is a hotfix release to address an issue in the dispute coordinator on the node level. ## How to test: Please provide a brief step-by-step instruction. If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.) - Step 1 - Step 2 - etc. ## Checklist: - [ ] I have verified that the code works - [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use `get(3)`, ...) - [ ] I have verified that the code is easy to understand - [ ] If not, I have left a well-balanced amount of inline comments - [ ] I have [left the code in a better state](https://deviq.com/principles/boy-scout-rule) - [ ] I have documented the changes (where applicable) Co-authored-by: Antonio <[email protected]>

@weichweich

## fixes KILTProtocol/ticket#2392 ## Breaking Changes for us ~~None! 🥳~~ Edit: Forgot to also check with try-runtime feature enabled. There is a small tweak necessary because of [This PR about on-runtime-upgrade](paritytech/substrate#13045) No database migrations, no runtime migrations and no new host functions. ## Polkadot Release Link https://github.com/paritytech/polkadot/releases/tag/v0.9.37 ## Release Analysis Forum Post https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-37/1736 ## Cool new stuff that might be useful (or not) * [frame_support::storage: Add StorageStreamIter](paritytech/substrate#12721) * If we have a StorageValue that contains something iterable, we can directly iterate over it, without copying the memory first by a regular get() call. * [Add ensure_* mathematical methods](paritytech/substrate#12754) * The checked_* family of calls returns an Option which is in 99% of the cases mapped to an error * ensure_* calls directly return an error which can be propagated using questionmark operator more easily * [Kusama shows how to express complex local origins in XCM messages](paritytech/polkadot#6273) * Perhaps the most interesting one in this release, would be a good idea for @weichweich and @ntn-x2 to have a look into this * [pallet_uniques successor NFTv2 is out! 🥳 😄 ](paritytech/substrate#12765) * Finally we can have NFTs with owner controlled metadata on our chain. * They even literally mention that this way users can write DIDs directly on their NFT!

Brings the two runtimes back to sync. The diff between the peregrine and spiritnet runtime is now minimal again. Also one comment was outdated and the public credentials are not part of the benchmarks for spiritnet.

Fixes KILTprotocol/ticket#2327 and fixes KILTprotocol/ticket#2325. Adds a creation block number to future CTypes, and it introduces a `set_block_number` extrinsic that can be called **by sudo on standalone, Peregrine and Spiritnet**. Co-authored-by: Albrecht <[email protected]>

## fixes KILTprotocol/ticket#2388 Since Peregrine fix tags didn't contain `-rc-` the CI pushed them as latest. This commit undo [this commit ](3a852e5) ## Checklist: - [ ] I have verified that the code works - [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use `get(3)`, ...) - [ ] I have verified that the code is easy to understand - [ ] If not, I have left a well-balanced amount of inline comments - [ ] I have [left the code in a better state](https://deviq.com/principles/boy-scout-rule) - [ ] I have documented the changes (where applicable)

There were few things that, as far as I have understood, were not 100% consistent with what the chain does and especially does NOT do, right now. More details are provided as comments in the files.

A while ago, we have migrated to using the `StorageVersion` way of declaring the storage version for our pallets. Nevertheless, we were not aware that such a change would only be written to storage either explicitly in a storage migration for live chains, or at genesis for new chains. This means that we have few places where the declared storage version, which is a `const` inside each pallet, does not reflect what is written on chain in the relative entry. This means that, for the future, **every time we add a new pallet we must also include the storage migration to write the value of the storage version on chain**. ### Peregrine The `attestation` and `publicCredentials` pallet expose a `StorageVersion` of 1, but the on-chain value is 0. ### Spiritnet It has the same issue as Peregrine, with the addition of the `web3Names` pallet as well. This PR then exposes a pre-runtime hook that logs with a warning all pallets that suffer from this inconsistency, and a post-runtime check that verifies that everything has been fixed. #### Note The migration that updates the storage version has to be run last, so that pre- and post- runtime hooks don't trigger any unexpected behaviour. ## How to test Compile the `kilt-parachain` binary with `cargo build -p kilt-parachain --features try-runtime`. For Peregrine, run: ```bash ./target/debug/kilt-parachain try-runtime \ --runtime target/debug/wbuild/peregrine-runtime/peregrine_runtime.compact.compressed.wasm \ -lruntime=info \ on-runtime-upgrade --checks \ live --uri wss://peregrine.kilt.io:443/parachain-public-ws ``` For Spiritnet, run: ```bash ./target/debug/kilt-parachain try-runtime \ --runtime target/debug/wbuild/spiritnet-runtime/spiritnet_runtime.compact.compressed.wasm \ -lruntime=info \ on-runtime-upgrade --checks \ live --uri wss://spiritnet.kilt.io:443 ```

…"""

trusch · 2023-02-01T12:54:00Z

.maintain/srtool.Dockerfile

@@ -3,7 +3,7 @@ FROM docker.io/library/ubuntu:22.04
 LABEL maintainer "[email protected]"
 LABEL description="This image contains tools for Substrate blockchains runtimes."

-ARG RUSTC_VERSION="1.62.0"
+ARG RUSTC_VERSION="1.64.0"


This doesn't match with the latest srtool version (1.66.1) thats also used in the CI script

runtimes/spiritnet/src/lib.rs

ntn-x2 · 2023-02-01T15:03:44Z

cc @weichweich once you're back. We will deploy on staging by end of the week but wait for your pair of eyes before merging and releasing on Peregrine.

trusch

To me this looks good, all important stuff seems to be there. I'd say we create an rc from this and continue testing on staging 🎉

weichweich

LGTM

Some calls are heavier now, for no apparent reason.

weichweich · 2023-02-06T08:33:44Z

pallets/attestation/src/default_weights.rs

 			.saturating_add(T::DbWeight::get().reads(2 as u64))
 			.saturating_add(T::DbWeight::get().writes(2 as u64))
 	}
 	// Storage: Attestation Attestations (r:1 w:1)
 	// Storage: System Account (r:1 w:1)
 	fn reclaim_deposit() -> Weight {
-		Weight::from_ref_time(51_952_000 as u64)
+		Weight::from_ref_time(115_795_000 as u64)


The weights of remove, reclaim_deposit, change_deposit_owner, update_deposit increased a lot.

weichweich · 2023-02-06T08:44:15Z

pallets/did/src/default_weights.rs

 			.saturating_add(T::DbWeight::get().reads(2 as u64))
 			.saturating_add(T::DbWeight::get().writes(2 as u64))
 	}
 	// Storage: Did Did (r:1 w:0)
 	/// The range of component `l` is `[1, 5242880]`.
 	fn signature_verification_sr25519(l: u32, ) -> Weight {
-		Weight::from_ref_time(29_998_000 as u64)


Also increased a bit

weichweich · 2023-02-06T08:45:59Z

pallets/pallet-did-lookup/src/default_weights.rs

 			.saturating_add(T::DbWeight::get().reads(2 as u64))
 			.saturating_add(T::DbWeight::get().writes(4 as u64))
 	}
 	// Storage: System Account (r:1 w:1)
 	// Storage: DidLookup ConnectedDids (r:1 w:1)
 	// Storage: DidLookup ConnectedAccounts (r:0 w:2)
 	fn associate_sender() -> Weight {
-		Weight::from_ref_time(72_677_000 as u64)
+		Weight::from_ref_time(172_109_000 as u64)


Increased and seems counter intuitive. associate_account does 2 signature checks while associate_sender only 1. but associate_sender is significantly heavier.

weichweich · 2023-02-06T08:47:57Z

pallets/pallet-did-lookup/src/default_weights.rs

 			.saturating_add(T::DbWeight::get().reads(2 as u64))
 			.saturating_add(T::DbWeight::get().writes(3 as u64))
 	}
 	// Storage: DidLookup ConnectedDids (r:1 w:1)
 	// Storage: System Account (r:1 w:1)
 	// Storage: DidLookup ConnectedAccounts (r:0 w:1)
 	fn remove_account_association() -> Weight {
-		Weight::from_ref_time(54_561_000 as u64)
+		Weight::from_ref_time(111_285_000 as u64)


These things also increased; remove_account_association, change_deposit_owner

weichweich · 2023-02-06T08:51:16Z

pallets/pallet-inflation/src/default_weights.rs

@@ -56,24 +56,24 @@ pub struct SubstrateWeight<T>(PhantomData<T>);
 impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 	// Storage: System Account (r:1 w:1)
 	fn on_initialize_mint_to_treasury() -> Weight {
-		Weight::from_ref_time(37_539_000 as u64)
+		Weight::from_ref_time(81_256_000 as u64)


These increases seem to be random.

weichweich · 2023-02-06T08:53:18Z

pallets/pallet-web3-names/src/default_weights.rs

-			// Standard Error: 2_000
-			.saturating_add(Weight::from_ref_time(10_000 as u64).saturating_mul(n as u64))
+	fn claim(_n: u32, ) -> Weight {
+		Weight::from_ref_time(79_918_651 as u64)


This increased a little but is now independent from the length of the name

weichweich · 2023-02-06T08:53:45Z

pallets/pallet-web3-names/src/default_weights.rs

 			.saturating_add(T::DbWeight::get().reads(4 as u64))
 			.saturating_add(T::DbWeight::get().writes(3 as u64))
 	}
 	// Storage: Web3Names Names (r:1 w:1)
 	// Storage: Web3Names Owner (r:1 w:1)
 	// Storage: System Account (r:1 w:1)
 	fn release_by_owner() -> Weight {
-		Weight::from_ref_time(56_091_000 as u64)
+		Weight::from_ref_time(115_743_000 as u64)


twice as high

weichweich · 2023-02-06T08:54:15Z

pallets/pallet-web3-names/src/default_weights.rs

-			// Standard Error: 1_000
-			.saturating_add(Weight::from_ref_time(40_000 as u64).saturating_mul(n as u64))
+	fn unban(_n: u32, ) -> Weight {
+		Weight::from_ref_time(38_246_474 as u64)
 			.saturating_add(T::DbWeight::get().reads(1 as u64))


This is also independent from the length now

weichweich · 2023-02-06T09:38:40Z

runtimes/spiritnet/src/weights/attestation.rs

@@ -52,41 +52,41 @@ impl<T: frame_system::Config> attestation::WeightInfo for WeightInfo<T> {
 	// Storage: Attestation Attestations (r:1 w:1)
 	// Storage: System Account (r:1 w:1)
 	fn add() -> Weight {
-		Weight::from_ref_time(56_234_000 as u64)


twice as high

weichweich · 2023-02-06T09:39:47Z

runtimes/spiritnet/src/weights/pallet_balances.rs

@@ -50,43 +50,43 @@ pub struct WeightInfo<T>(PhantomData<T>);
 impl<T: frame_system::Config> pallet_balances::WeightInfo for WeightInfo<T> {
 	// Storage: System Account (r:2 w:2)
 	fn transfer() -> Weight {
-		Weight::from_ref_time(87_075_000 as u64)
+		Weight::from_ref_time(207_389_000 as u64)


twice as high

ntn-x2 · 2023-02-06T13:30:18Z

@weichweich there has been quite some work on the benchmarking side, so I guess these results are a consequence of those. I have no other clear explanation for these new weights. Some weights have gone up, many others have gone down, and some even do not depend on the input anymore, which hints at a different way of fitting the numbers together. I would not be too worried.

wischli and others added 30 commits November 4, 2022 14:53

chore: bump version to 1.9.0

199e65e

fix: yorlin keys (#432)

c595a47

## fixes [KILTProtocol/ticket#2255](https://github.com/KILTprotocol/ticket/issues/2255)

chore: renaming runtime APIs for public credentials (#433)

8fe2c4d

chore: bump spec versions to 10902

0d0044b

Revert "chore: bump spec versions to 10902"

d67c5c4

This reverts commit 0d0044b.

ci: build latest only on non rc tags

db1687f

chore: update bootnodes (#435)

5f8b12c

Revert "feat: support linking ethereum accounts (#355)"

655b923

This reverts commit c8f4577.

feat: remove public credentials from spiritnet

6c0bded

we test first on peregrine and will later enable this feature on spiritnet

chore: update weights

654d00b

Revert "Revert "feat: support linking ethereum accounts (#355)""

621997e

This reverts commit df5abe3.

Revert "feat: remove public credentials from spiritnet"

6185e94

This reverts commit 6d4fcc6.

fix: apply new toolchain to init script

81d881a

fix: staking API unclaimed rewards

70ba5ba

ci: add img build for dev tags

3a852e5

fix: disable curl output (#444)

4ac7610

## fixes NO TICKET

fix: new spec (#443)

8be0c41

New Relaychain spec, code substitute for peregrine Co-authored-by: William Freudenberger <[email protected]>

fix: toolchain version (#447)

5a85bf4

chore: make clear that it's still under development (#451)

79ac365

## fixes https://github.com/KILTprotocol/ticket/issues/2387

chore: update relay chain references (#449)

b6b8d4d

After the move to Polkadot, Spiritnet XCM config was still referring to Kusama as the relay chain. This should be updated now. Co-authored-by: Albrecht <[email protected]>

chore: update srtool (#453)

eecde66

fix: add public credentials to benchmark (#455)

59f8452

Brings the two runtimes back to sync. The diff between the peregrine and spiritnet runtime is now minimal again. Also one comment was outdated and the public credentials are not part of the benchmarks for spiritnet.

chore: remove clone runtime (#456)

a12b0c8

ntn-x2 and others added 6 commits January 26, 2023 08:42

chore: refactor some more XCM config stuff (#457)

519ff06

There were few things that, as far as I have understood, were not 100% consistent with what the chain does and especially does NOT do, right now. More details are provided as comments in the files.

Merge remote-tracking branch 'origin/develop' into release-1.9.0

7d56019

chore: remove unused dependency

1566d84

Revert "Revert "Revert "feat: support linking ethereum accounts (#355)…

8964b10

…"""

chore: bump crates version to 1.9.0 and specs version to 1.8.9 (10890)

0f39ffe

ntn-x2 added the 🛑 dont-merge DONT MERGE label Feb 1, 2023

ntn-x2 requested a review from trusch February 1, 2023 10:22

ntn-x2 self-assigned this Feb 1, 2023

ntn-x2 marked this pull request as ready for review February 1, 2023 11:02

trusch reviewed Feb 1, 2023

View reviewed changes

runtimes/spiritnet/src/lib.rs Show resolved Hide resolved

ntn-x2 added 2 commits February 1, 2023 15:14

Add missed migrations

5ea142e

Add balances pallet migration with no accounts

c1fd840

ntn-x2 requested a review from trusch February 1, 2023 14:55

trusch approved these changes Feb 1, 2023

View reviewed changes

Benchmarks

82308ce

weichweich approved these changes Feb 6, 2023

View reviewed changes

ntn-x2 merged commit 82308ce into master Feb 8, 2023

ntn-x2 deleted the release-1.9.0 branch February 8, 2023 12:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] feat: 1.9.0 release #460

[DO NOT MERGE] feat: 1.9.0 release #460

ntn-x2 commented Feb 1, 2023 •

edited

Loading

trusch Feb 1, 2023

ntn-x2 commented Feb 1, 2023

trusch left a comment

weichweich left a comment

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

weichweich Feb 6, 2023

ntn-x2 commented Feb 6, 2023

[DO NOT MERGE] feat: 1.9.0 release #460

[DO NOT MERGE] feat: 1.9.0 release #460

Conversation

ntn-x2 commented Feb 1, 2023 • edited Loading

Edit

TODO

Choose a reason for hiding this comment

ntn-x2 commented Feb 1, 2023

trusch left a comment

Choose a reason for hiding this comment

weichweich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntn-x2 commented Feb 6, 2023

ntn-x2 commented Feb 1, 2023 •

edited

Loading