Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade polkadot to v0.9.36 #446

Merged
merged 11 commits into from
Jan 20, 2023
Merged

Conversation

trusch
Copy link
Contributor

@trusch trusch commented Jan 6, 2023

fixes KILTProtocol/ticket#2351

Upgrade polkadot version to 0.9.36

Notable changes in 0.9.32 -> 0.9.33

Full changelog

This release is super small and only consists of removing the sp_tasks::spawn api, that wasn't used by us or any others (paritytech/substrate#12639). The only other change was an internal refactoring of the state database in paritytech/substrate#12239

Notable changes in 0.9.33 -> 0.9.34

Full changelog

This is a bigger runtime only release mainly about improvements to opengov and collectives. The only notable change that required code changes was the removal of the wasmtime feature flag in some crates paritytech/substrate#12684

Notable changes in 0.9.34 -> 0.9.35

Full changelog

Most notable are the two changes paritytech/substrate#12891
and paritytech/substrate#12868. Also there is now the possibility to use a new RPC server that supports http and websocket requests on the same server. We should look into this since this will eventually cause the older severs to be deprecated in the future (paritytech/substrate#12663). In paritytech/substrate#12485 a general message queue pallet was introduced that might be helpful for receivng XCM in the future.

Notable changes in 0.9.35 -> 0.9.36

Full changelog

This is a hotfix release to address an issue in the dispute coordinator on the node level.

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@trusch trusch requested a review from weichweich January 6, 2023 10:02
upgrade polkadot to v0.9.36

give explicit method indexes to all our extrinsics
@trusch trusch force-pushed the feature/polkadot-upgrade-v0.9.36 branch from 9e9aa29 to 0f7ccbd Compare January 6, 2023 11:18
@trusch trusch marked this pull request as ready for review January 6, 2023 11:24
nodes/standalone/Cargo.toml Outdated Show resolved Hide resolved
runtimes/spiritnet/src/lib.rs Outdated Show resolved Hide resolved
runtimes/standalone/src/lib.rs Outdated Show resolved Hide resolved
@trusch trusch changed the title chore: upgrade polkadot to v0.9.36 chore: upgrade polkadot to v0.9.36 #446 Jan 10, 2023
@trusch trusch changed the title chore: upgrade polkadot to v0.9.36 #446 chore: upgrade polkadot to v0.9.36 Jan 10, 2023
@ntn-x2
Copy link
Member

ntn-x2 commented Jan 13, 2023

@trusch as an exercise, but also for future migrations PRs, would you mind to change the PR description to follow the traces of what William used to do for migration PRs? E.g., #434. This helps finding out potential stuff that has changed to you, while going over the changes, and to us, while reviewing the PR. There has already been few cases where parachains have stalled because of some missed migrations or storage changes 😋 I did check that there was no relevant migration for us, but for the sake of traceability, it would be good to have a good PR description for upgrades, especially when updating 4 versions at once 🙏🙏🙏

runtimes/clone/src/lib.rs Outdated Show resolved Hide resolved
runtimes/peregrine/src/lib.rs Outdated Show resolved Hide resolved
runtimes/standalone/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would love to create a diff of our metadata for this release (because of the extrinsic indices). But that'll be another task.

@ntn-x2
Copy link
Member

ntn-x2 commented Jan 20, 2023

I would love to create a diff of our metadata for this release (because of the extrinsic indices). But that'll be another task.

This will be done anyway in the SDK when we re-run type augmentation. But anyway it could be part of https://github.com/KILTprotocol/ticket/issues/2241 or at least related to it.

@trusch trusch merged commit b38b92a into develop Jan 20, 2023
@trusch trusch deleted the feature/polkadot-upgrade-v0.9.36 branch January 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants