Various upgrades and modernisation #3
Conversation
* Update to modern libraries, including avoiding those with published security issues * Add `roave/security-advisories` to check on update for future upstream library security issues * Remove support for PHP versions no longer in active maintenance; add support for modern versions * Replace non-binary safe `fopen()` calls with flexible PSR-3 log adapter support * Make extension requirements explicit in `composer.json` * Expand use of types and strict comparisons * Other minor tidying, PSR-2 fixes & removal of some dead code
|
@JustinBusschau please take this with a small pinch of salt for now, as I've not yet tried it out downstream with e.g. I have one potentially key question so far I'd like to clarify: What's an example of It would be great to hear any thoughts you have generally, and whether you think this sits best in your fork or is something it would make sense for us to publish separately under |
See JustinBusschau/php-govtalk#3 for a guide to what some of the remaining changes will need to look like. To maintain Guzzle library cross-compatability etc., another requirement for this update will be for the upstream `php-govtalk` to be swapped over to its v1.x (if updated in situ) or to the `thebiggive` fork.
|
@NoelLH at a quick glance the changes look good. To be frank, I don't have the time to maintain this repo. I'm very happy it's been useful to you - perhaps you should take a fork and move it to |
|
Thanks for confirming @JustinBusschau, and for all your work on this in the past – much appreciated. I'll close this and am proceeding in our namespace at https://github.com/thebiggive/php-govtalk as you suggest. |
roave/security-advisoriesto check on update for future upstream library security issuesfopen()calls with flexible PSR-3 log adapter supportcomposer.json