Prepare for react 16.9 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2019
Closed
toolness
added a commit
that referenced
this pull request
Aug 16, 2019
In #811, I prematurely upgraded us to the very latest version of React Testing Library, which expects React 16.9 and logs a warning if it's not there. This adds spam to our test output, so I'm reverting to a version of RTL that doesn't require 16.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #810 which implements most of its changes, but keeps us on 16.8, so that it's easier to upgrade to 16.9 once all our dependencies (specifically react-aria-modal) catch up with it.
To summarize, it: