Parametric getParametricMeasurement and CalcFactorMahalanobis #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
commented
Jan 29, 2021
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
+ Coverage 70.27% 72.27% +2.00%
==========================================
Files 55 55
Lines 4282 4638 +356
==========================================
+ Hits 3009 3352 +343
- Misses 1273 1286 +13
Continue to review full report at Codecov.
|
dehann
approved these changes
Jan 29, 2021
| cfp.calcfactor!(res, cfp.meanVal, variables...) | ||
| res = Vector{eltype(variables[1])}(undef, length(cfp.meas)) | ||
| iΣ = cfp.iΣ | ||
| cfp.calcfactor!(res, cfp.meas, variables...) |
There was a problem hiding this comment.
Yep, this is where the action is at (to consolidate nonparametric and parametric) and looks right to me, thanks!
PS, afterward we can worry about expanding both '(measurement..., variables...)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards consolidation creates residual using
eltypeof variable[1].residual not buffered though, but not to bad.