Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing deprecation UnitQuaterion #781

Merged
merged 2 commits into from
Nov 22, 2021
Merged

fix missing deprecation UnitQuaterion #781

merged 2 commits into from
Nov 22, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Nov 22, 2021

No description provided.

@dehann
Copy link
Member Author

dehann commented Nov 22, 2021

xref JuliaGeometry/Rotations.jl#175

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #781 (cf81ac7) into master (1bfc7c1) will increase coverage by 7.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage    4.08%   11.22%   +7.13%     
==========================================
  Files          46       47       +1     
  Lines        2690     2699       +9     
==========================================
+ Hits          110      303     +193     
+ Misses       2580     2396     -184     
Impacted Files Coverage Δ
src/3rdParty/_PCL/services/PointCloud.jl 68.05% <100.00%> (+7.63%) ⬆️
src/zmq/models/session.jl 100.00% <0.00%> (ø)
.../zmq/services/factors/distributionSerialization.jl 23.52% <0.00%> (+23.52%) ⬆️
src/images/AprilTagDrawingTools.jl 25.00% <0.00%> (+25.00%) ⬆️
src/images/ScatterAlignPose2.jl 32.00% <0.00%> (+32.00%) ⬆️
src/zmq/services/factors/factorSerialization.jl 36.36% <0.00%> (+36.36%) ⬆️
src/zmq/services/session.jl 69.30% <0.00%> (+69.30%) ⬆️
src/images/Pose2AprilTag4Corners.jl 76.00% <0.00%> (+76.00%) ⬆️
src/zmq/ZmqCaesar.jl 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfc7c1...cf81ac7. Read the comment docs.

@dehann dehann self-assigned this Nov 22, 2021
@dehann dehann merged commit 2bd3317 into master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants