Add abline! which creates a straight line according to the formula b+…

[pkofod]

…a*x.

Implements #125 . The syntax matches with the name such that abline!(a, b) adds a straight line b+a*x based on only x-min and x-max.

Does it match with your usual style of coding @tbreloff or are there any changes you would like?

[tbreloff]

Thanks... There's a couple things...

• the method should take a "plt::Plot" as the first argument and pass that as the first argument in your inner call to 'plot!'. Then you can add the convenience "abline!(args...; kw...) = abline!(current(), args...; kw...)"
• min/max should look at all series, not just the first

Thanks for the PR

On Feb 2, 2016, at 4:06 PM, Patrick Kofod Mogensen [email protected] wrote:

…a*x.

Implements #125 . The syntax matches with the name such that abline!(a, b) adds a straight line b+a*x based on only x-min and x-max.

Does it match with your usual style of coding @tbreloff or are there any changes you would like?

You can view, comment on, or merge this pull request online at:

#126

Commit Summary

Add abline! which creates a straight line according to the formula b+a*x.
File Changes

M src/recipes.jl (5)
Patch Links:

https://github.com/tbreloff/Plots.jl/pull/126.patch
https://github.com/tbreloff/Plots.jl/pull/126.diff
—
Reply to this email directly or view it on GitHub.

[pkofod]

Great suggestions. I just amended the changes, but I think you should be able to see the changes.

[pkofod]

Do you want xmin and xmax be exposed to the users?

[pkofod]

The failing CI seems to be comming from Gadfly markers, so it must be from the state of dev, not my PR. Added Base.extrema(plt::Plot) and changed code accordingly.

[tbreloff]

Yes I need to track down the markers behavior... Don't worry about that.

This looks good... Can you post an example png here for reference? I'll merge today.

On Feb 3, 2016, at 4:42 AM, Patrick Kofod Mogensen [email protected] wrote:

The failing CI seems to be comming from Gadfly markers, so it must be from the state of dev, not my PR. Added Base.extrema(plt::Plot) and changed code accordingly.

—
Reply to this email directly or view it on GitHub.

[pkofod]

I will do that. Do you want xmin, xmax and extrema exported?

[pkofod]

using Plots

# The first series contains xmax, the second contains xmin
x1 = [1; 4; 10; 30]
y1 = [0; 10; 3; 5]

x2 = [2; 8; 15; 35]
y2 = [3; 5; 4; 8]

plot([x1 x2], [y1 y2])

abline!(0.2, 2)

#or
# plt = plot([x1 x2], [y1 y2])
# abline!(plt, 0.2, 2)

png("abline")

[tbreloff]

No... there's no need to export extrema, as it's defined in base, and I don't think people should need xmin/xmax directly (and it can always be qualified). I just have a feeling I might want to change those names someday.

On Feb 3, 2016, at 8:17 AM, Patrick Kofod Mogensen [email protected] wrote:

I will do that. Do you want xmin, xmax and extrema exported?

—
Reply to this email directly or view it on GitHub.

[pkofod]

Okay! I guess you could always deprecate them, but on the other hand I don't see a lot of requests for them either in other issues :) They'll remain unexported. Then I think we should be good to merge. Do you want me to squash the commits?

[tbreloff]

Merged... thanks for the contribution. I'm happy to get more people involved to push this forward.