Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MPIPreferences subpackage to select binary #541

Merged
merged 54 commits into from
Apr 13, 2022
Merged

Add MPIPreferences subpackage to select binary #541

merged 54 commits into from
Apr 13, 2022

Conversation

simonbyrne
Copy link
Member

Based on #528 and #529.

@simonbyrne
Copy link
Member Author

Note that the spurious tests are passing due to JuliaLang/Pkg.jl#2920

@simonbyrne
Copy link
Member Author

@vchuravy @staticfloat: until JuliaLang/Pkg.jl#2920 makes it into a new release, is there a way to work around the problem for testing purposes?

@simonbyrne simonbyrne closed this Feb 18, 2022
@simonbyrne simonbyrne reopened this Feb 18, 2022
@simonbyrne simonbyrne marked this pull request as ready for review February 21, 2022 06:08
giordano
giordano reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed how the constants have been generated. It'd be good to have a reproducible way to update them, if needed.

Also, the documentation should also be updated, right?

.gitignore Outdated Show resolved Hide resolved
src/MPI.jl Outdated Show resolved Hide resolved
src/consts/consts.jl Outdated Show resolved Hide resolved
lib/MPIPreferences/src/MPIPreferences.jl
if (m = match(r"CRAY MPICH version (\d+.\d+.\d+)", version_string)) !== nothing
version = VersionNumber(m.captures[1])
end
elseif startswith(version_string, "FUJITSU MPI")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this breaks the idea of #542 😄

lib/MPIPreferences/src/MPIPreferences.jl Outdated Show resolved Hide resolved
@vchuravy
Copy link
Member

makes it into a new release, is there a way to work around the problem for testing purposes?

Is
https://github.com/EnzymeAD/Enzyme.jl/blob/d774adc69a5c724246f9854b380761cdaba9d80c/test/runtests.jl#L1-L7 what you need?

@vchuravy vchuravy mentioned this pull request Mar 3, 2022
Merged
@vchuravy
Copy link
Member

vchuravy commented Mar 4, 2022

@JuliaRegistrator register subdir=lib/MPIPreferences

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

vchuravy
vchuravy reviewed Mar 4, 2022
View reviewed changes
src/MPI.jl Outdated Show resolved Hide resolved
vchuravy
vchuravy reviewed Mar 4, 2022
View reviewed changes
src/consts/microsoftmpi.jl Outdated Show resolved Hide resolved
@vchuravy vchuravy mentioned this pull request Mar 6, 2022
Closed
@simonbyrne simonbyrne merged commit 890ee6e into master Apr 13, 2022
@simonbyrne simonbyrne deleted the sb/mpipref branch April 13, 2022 05:37
@giordano giordano linked an issue Apr 18, 2022 that may be closed by this pull request
Unknown MPI ABI when using Fujitsu MPI on Fugaku, and segmentation faults when running the tests with this implementation #539
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggouaillardet ggouaillardet ggouaillardet left review comments

@bgoglin bgoglin bgoglin left review comments

@giordano giordano giordano left review comments

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@simonbyrne @vchuravy @JuliaRegistrator @giordano @bgoglin @ggouaillardet