Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI platform tag and have LAMMPS use it #4540

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Mar 3, 2022

Based off JuliaParallel/MPI.jl#541 (but also independent enough that we can use it before that lands)

Replaces #4073

platforms/mpi.jl Outdated Show resolved Hide resolved
@vchuravy
Copy link
Member Author

vchuravy commented Mar 3, 2022

@giordano and @staticfloat this reminded me that we don't record the compat of JLL packages against dependencies all that much. Here I wanted to make sure that I honor the major version compat of MPITrampoline.
Should we not autogenerate a compat for major version for most JLL?

@vchuravy vchuravy merged commit c6e365e into master Mar 3, 2022
@vchuravy vchuravy deleted the vc/mpi_platform branch March 3, 2022 21:54
@giordano
Copy link
Member

giordano commented Mar 3, 2022

Should we not autogenerate a compat for major version for most JLL?

It's complicated. We generally follow upstream version numbers, but they do not adhere to semver: they can introduce breaking changes in patch or minor versions (MbedTLS anyone?), or bump the major version just for the sake of it even though there is no ABI/API breakage. This means that using compat bounds can both be too restrictive or not be helpful in preventing breakage. Basically, it's a mess. In #3024 I'm keeping a list of packages for which we know we really should specify compat bounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants